fwupdmgr removed GRUB from my UEFI boot list

[Marius Gedminas]

== Introduction ==

This is going to sound very similar to bug 1900121, but I believe it's a different bug.

Today I tried to upgrade the system firmware and the Intel ME firmware on my ThinkPad X390 with `fwupdmgr upgrade` (after attempting to upgrade with snap-store failed with no indication of what was wrong, but that's not related to this bug).

When `fwupdmgr` asked me to reboot, I confirmed, and then I was called away from my laptop for a few minutes. I didn't see what happened during boot, but when I came back, I found my laptop booted into Windows. (This is a bug -- bug 1900121 probably -- but not the bug I'm reporting now). Since I was already there, I let Windows install its updates, which could be important. A few Windows reboots later I went into the UEFI setup to restore Ubuntu in the boot priority list, but I didn't find it there.

Then I booted a GRUB shell from a USB drive (by pressing F12 to get the boot menu), used `configfile (hd1,gpt1)/efi/ubuntu/grub.cfg` to boot my primary OS, and restored the `ubuntu` boot entry by running `sudo grub-install /dev/nvme0n1`.

Then I checked with `sudo fwupdmgr upgrade` whether the firmware upgrades had been applied or not. They had not, so I let fwupdmgr install them. Then I did not let fwupdmgr reboot but decided to check the boot priority list in `efibootmgr -v`.

== The bug ==

fwupdmgr removed the `ubuntu` entry and replaced it with a second copy of the `Linux-Firmware-Updater` boot entry.

I suspect it's because the BootCurrent was pointing to the USB flash drive that I used for recovery, rather than the regular ubuntu entry.

== Details ==

efibootmgr -v when I rescue-booted:

    | BootCurrent: 001E
    | Timeout: 0 seconds
    | BootOrder: 001A,0000,0018,0019,001B,001C,001D,001E,001F,0020,0021,0002,0027
    | Boot0000* Windows Boot Manager HD(1,GPT,efd54dec-f70c-4b32-9480-c2dd0043ea0d,0x800,0x82000)/File(\EFI\Microsoft\Boot\bootmgfw.efi)WINDOWS.........x...B.C.D.O.B.J.E.C.T.=.{.9.d.e.a.8.6.2.c.-.5.c.d.d.-.4.e.7.0.-.a.c.c.1.-.f.3.2.b.3.4.4.d.4.7.9.5.}...e.............^?...
    | Boot0002* Linux-Firmware-Updater HD(1,GPT,efd54dec-f70c-4b32-9480-c2dd0043ea0d,0x800,0x82000)/File(\EFI\ubuntu\shimx64.efi)\.f.w.u.p.d.x.6.4...e.f.i...
    | Boot0010 Setup FvFile(721c8b66-426c-4e86-8e99-3457c46ab0b9)
    | Boot0011 Boot Menu FvFile(126a762d-5758-4fca-8531-201a7f57f850)
    | Boot0012 Diagnostic Splash Screen FvFile(a7d8d9a6-6ab0-4aeb-ad9d-163e59a7a380)
    | Boot0013 Lenovo Diagnostics FvFile(3f7e615b-0d45-4f80-88dc-26b234958560)
    | Boot0014 Regulatory Information FvFile(478c92a0-2622-42b7-a65d-5894169e4d24)
    | Boot0015 Startup Interrupt Menu FvFile(f46ee6f4-4785-43a3-923d-7f786c3c8479)
    | Boot0016 Rescue and Recovery FvFile(665d3f60-ad3e-4cad-8e26-db46eee9f1b5)
    | Boot0017 MEBx Hot Key FvFile(ac6fd56a-3d41-4efd-a1b9-870293811a28)
    | Boot0018* USB CD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,86701296aa5a7848b66cd49dd3ba6a55)
    | Boot0019* USB FDD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,6ff015a28830b543a8b8641009461e49)
    | Boot001A* NVMe0 VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,001c199932d94c4eae9aa0b6e98eb8a400)
    | Boot001B* NVMe1 VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,001c199932d94c4eae9aa0b6e98eb8a401)
    | Boot001C* ATA HDD0 VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,91af625956449f41a7b91f4f892ab0f602)
    | Boot001D* ATA HDD1 VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,91af625956449f41a7b91f4f892ab0f601)
    | Boot001E* USB HDD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,33e821aaaf33bc4789bd419f88c50803)
    | Boot001F* PXE BOOT VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,78a84aaf2b2afc4ea79cf5cc8f3d3803)
    | Boot0020 Other CD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,aea2090adfde214e8b3a5e471856a35406)
    | Boot0021 Other HDD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,91af625956449f41a7b91f4f892ab0f606)
    | Boot0022* IDER BOOT CDROM PciRoot(0x0)/Pci(0x14,0x0)/USB(11,1)
    | Boot0023* IDER BOOT Floppy PciRoot(0x0)/Pci(0x14,0x0)/USB(11,0)
    | Boot0024* ATA HDD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,91af625956449f41a7b91f4f892ab0f6)
    | Boot0025* ATAPI CD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,aea2090adfde214e8b3a5e471856a354)
    | Boot0026 ThinkShield secure wipe FvFile(3593a0d5-bd52-43a0-808e-cbff5ece2477)
    | Boot0027* LENOVO CLOUD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,ad38ccbbf7edf04d959cf42aa74d3650)/Uri(https://download.lenovo.com/pccbbs/cdeploy/efi/boot.efi)
    | Boot0001* ubuntu HD(1,MBR,0x224ca4b1,0x1ad80,0x7359280)/File(\EFI\ubuntu\shimx64.efi)

efibootmgr -v after I ran grub-install /dev/nvme0n1

    | BootCurrent: 001E
    | Timeout: 0 seconds
    | BootOrder: 0001,001A,0000,0018,0019,001B,001C,001D,001E,001F,0020,0021,0002,0027
    | Boot0000* Windows Boot Manager HD(1,GPT,efd54dec-f70c-4b32-9480-c2dd0043ea0d,0x800,0x82000)/File(\EFI\Microsoft\Boot\bootmgfw.efi)WINDOWS.........x...B.C.D.O.B.J.E.C.T.=.{.9.d.e.a.8.6.2.c.-.5.c.d.d.-.4.e.7.0.-.a.c.c.1.-.f.3.2.b.3.4.4.d.4.7.9.5.}...e.............^?...
    | Boot0001* ubuntu HD(1,GPT,efd54dec-f70c-4b32-9480-c2dd0043ea0d,0x800,0x82000)/File(\EFI\ubuntu\shimx64.efi)
    | Boot0002* Linux-Firmware-Updater HD(1,GPT,efd54dec-f70c-4b32-9480-c2dd0043ea0d,0x800,0x82000)/File(\EFI\ubuntu\shimx64.efi)\.f.w.u.p.d.x.6.4...e.f.i...
    | Boot0010 Setup FvFile(721c8b66-426c-4e86-8e99-3457c46ab0b9)
    | Boot0011 Boot Menu FvFile(126a762d-5758-4fca-8531-201a7f57f850)
    | Boot0012 Diagnostic Splash Screen FvFile(a7d8d9a6-6ab0-4aeb-ad9d-163e59a7a380)
    | Boot0013 Lenovo Diagnostics FvFile(3f7e615b-0d45-4f80-88dc-26b234958560)
    | Boot0014 Regulatory Information FvFile(478c92a0-2622-42b7-a65d-5894169e4d24)
    | Boot0015 Startup Interrupt Menu FvFile(f46ee6f4-4785-43a3-923d-7f786c3c8479)
    | Boot0016 Rescue and Recovery FvFile(665d3f60-ad3e-4cad-8e26-db46eee9f1b5)
    | Boot0017 MEBx Hot Key FvFile(ac6fd56a-3d41-4efd-a1b9-870293811a28)
    | Boot0018* USB CD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,86701296aa5a7848b66cd49dd3ba6a55)
    | Boot0019* USB FDD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,6ff015a28830b543a8b8641009461e49)
    | Boot001A* NVMe0 VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,001c199932d94c4eae9aa0b6e98eb8a400)
    | Boot001B* NVMe1 VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,001c199932d94c4eae9aa0b6e98eb8a401)
    | Boot001C* ATA HDD0 VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,91af625956449f41a7b91f4f892ab0f602)
    | Boot001D* ATA HDD1 VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,91af625956449f41a7b91f4f892ab0f601)
    | Boot001E* USB HDD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,33e821aaaf33bc4789bd419f88c50803)
    | Boot001F* PXE BOOT VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,78a84aaf2b2afc4ea79cf5cc8f3d3803)
    | Boot0020 Other CD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,aea2090adfde214e8b3a5e471856a35406)
    | Boot0021 Other HDD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,91af625956449f41a7b91f4f892ab0f606)
    | Boot0022* IDER BOOT CDROM PciRoot(0x0)/Pci(0x14,0x0)/USB(11,1)
    | Boot0023* IDER BOOT Floppy PciRoot(0x0)/Pci(0x14,0x0)/USB(11,0)
    | Boot0024* ATA HDD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,91af625956449f41a7b91f4f892ab0f6)
    | Boot0025* ATAPI CD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,aea2090adfde214e8b3a5e471856a354)
    | Boot0026 ThinkShield secure wipe FvFile(3593a0d5-bd52-43a0-808e-cbff5ece2477)
    | Boot0027* LENOVO CLOUD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,ad38ccbbf7edf04d959cf42aa74d3650)/Uri(https://download.lenovo.com/pccbbs/cdeploy/efi/boot.efi)

efibootmgr -v after fwupdmgr upgrade messed it up:

    | BootNext: 0001
    | BootCurrent: 001E
    | Timeout: 0 seconds
    | BootOrder: 0001,001A,0000,0018,0019,001B,001C,001D,001E,001F,0020,0021,0002,0027
    | Boot0000* Windows Boot Manager HD(1,GPT,efd54dec-f70c-4b32-9480-c2dd0043ea0d,0x800,0x82000)/File(\EFI\Microsoft\Boot\bootmgfw.efi)WINDOWS.........x...B.C.D.O.B.J.E.C.T.=.{.9.d.e.a.8.6.2.c.-.5.c.d.d.-.4.e.7.0.-.a.c.c.1.-.f.3.2.b.3.4.4.d.4.7.9.5.}...e................
    | Boot0001* Linux-Firmware-Updater HD(1,GPT,efd54dec-f70c-4b32-9480-c2dd0043ea0d,0x800,0x82000)/File(\EFI\ubuntu\shimx64.efi)\.f.w.u.p.d.x.6.4...e.f.i...
    | Boot0002* Linux-Firmware-Updater HD(1,GPT,efd54dec-f70c-4b32-9480-c2dd0043ea0d,0x800,0x82000)/File(\EFI\ubuntu\shimx64.efi)\.f.w.u.p.d.x.6.4...e.f.i...
    | Boot0010 Setup FvFile(721c8b66-426c-4e86-8e99-3457c46ab0b9)
    | Boot0011 Boot Menu FvFile(126a762d-5758-4fca-8531-201a7f57f850)
    | Boot0012 Diagnostic Splash Screen FvFile(a7d8d9a6-6ab0-4aeb-ad9d-163e59a7a380)
    | Boot0013 Lenovo Diagnostics FvFile(3f7e615b-0d45-4f80-88dc-26b234958560)
    | Boot0014 Regulatory Information FvFile(478c92a0-2622-42b7-a65d-5894169e4d24)
    | Boot0015 Startup Interrupt Menu FvFile(f46ee6f4-4785-43a3-923d-7f786c3c8479)
    | Boot0016 Rescue and Recovery FvFile(665d3f60-ad3e-4cad-8e26-db46eee9f1b5)
    | Boot0017 MEBx Hot Key FvFile(ac6fd56a-3d41-4efd-a1b9-870293811a28)
    | Boot0018* USB CD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,86701296aa5a7848b66cd49dd3ba6a55)
    | Boot0019* USB FDD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,6ff015a28830b543a8b8641009461e49)
    | Boot001A* NVMe0 VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,001c199932d94c4eae9aa0b6e98eb8a400)
    | Boot001B* NVMe1 VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,001c199932d94c4eae9aa0b6e98eb8a401)
    | Boot001C* ATA HDD0 VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,91af625956449f41a7b91f4f892ab0f602)
    | Boot001D* ATA HDD1 VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,91af625956449f41a7b91f4f892ab0f601)
    | Boot001E* USB HDD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,33e821aaaf33bc4789bd419f88c50803)
    | Boot001F* PXE BOOT VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,78a84aaf2b2afc4ea79cf5cc8f3d3803)
    | Boot0020 Other CD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,aea2090adfde214e8b3a5e471856a35406)
    | Boot0021 Other HDD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,91af625956449f41a7b91f4f892ab0f606)
    | Boot0022* IDER BOOT CDROM PciRoot(0x0)/Pci(0x14,0x0)/USB(11,1)
    | Boot0023* IDER BOOT Floppy PciRoot(0x0)/Pci(0x14,0x0)/USB(11,0)
    | Boot0024* ATA HDD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,91af625956449f41a7b91f4f892ab0f6)
    | Boot0025* ATAPI CD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,aea2090adfde214e8b3a5e471856a354)
    | Boot0026 ThinkShield secure wipe FvFile(3593a0d5-bd52-43a0-808e-cbff5ece2477)
    | Boot0027* LENOVO CLOUD VenMsg(bc7838d2-0f82-4d60-8316-c068ee79d25b,ad38ccbbf7edf04d959cf42aa74d3650)/Uri(https://download.lenovo.com/pccbbs/cdeploy/efi/boot.efi)

what fwupdmgr says it did:

    | • Thunderbolt Controller has the latest available firmware version
    | • Embedded Controller has the latest available firmware version
    | Upgrade available for Intel Management Engine from 192.71.1681 to 192.72.1757
    | 20Q0CTO1WW must remain plugged into a power source for the duration of the update to avoid damage. Continue with update? [Y|n]: y
    | Downloading… [***************************************] Less than one minute remaining…
    | Decompressing… [***************************************]
    | Authenticating… [***************************************]
    | Updating Intel Management Engine…********************************]
    | Scheduling… [***************************************]
    | Successfully installed firmware
    | • KXG6AZNV512G TOSHIBA has the latest available firmware version
    | • Prometheus has the latest available firmware version
    | • Prometheus IOTA Config has the latest available firmware version
    | Upgrade available for System Firmware from 0.1.70 to 0.1.71
    | 20Q0CTO1WW must remain plugged into a power source for the duration of the update to avoid damage. Continue with update? [Y|n]: y
    | Downloading… [***************************************] Less than one minute remaining…
    | Decompressing… [***************************************]
    | Authenticating… [***************************************]
    | Updating System Firmware…[***************************************]
    | Scheduling… [***************************************]
    | Successfully installed firmware
    | • UEFI Device Firmware has no available firmware updates
    | • UEFI Device Firmware has no available firmware updates
    |
    | An update requires a reboot to complete. Restart now? [y|N]:

ProblemType: Bug
DistroRelease: Ubuntu 20.10
Package: fwupd 1.4.5-1
ProcVersionSignature: Ubuntu 5.8.0-50.56-generic 5.8.18
Uname: Linux 5.8.0-50-generic x86_64
ApportVersion: 2.20.11-0ubuntu50.5
Architecture: amd64
CasperMD5CheckResult: skip
CurrentDesktop: ubuntu:GNOME
Date: Fri Apr 23 17:14:07 2021
EcryptfsInUse: Yes
InstallationDate: Installed on 2019-06-12 (680 days ago)
InstallationMedia: Ubuntu 19.04 "Disco Dingo" - Release amd64 (20190416)
SourcePackage: fwupd
UpgradeStatus: Upgraded to groovy on 2020-10-23 (182 days ago)
mtime.conffile..etc.fwupd.remotes.d.lvfs-testing.conf: 2020-11-18T10:25:54.540974
mtime.conffile..etc.fwupd.remotes.d.lvfs.conf: 2020-11-18T10:25:54.580976

[Marius Gedminas (mgedmin)]

Forwarded upstream to https://github.com/fwupd/fwupd/issues/3186

[Sebastien Bacher (seb128)]

Thanks for the details and also reporting upstream!

[Mario Limonciello (superm1)]

Upstream the leaning is this is a firmware implementation issue not a fwupd bug, so there is nothing fwupd can do about it today. If from some evidence or discussion that changes later we can re-open the issue.