Charm does not react to changes in 'source' charm config option

Bug #1924596 reported by Liam Young
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
charm-ovn-dedicated-chassis
Fix Released
High
Liam Young

Bug Description

Changing the charm source config option does not result in ovn being upgraded. To reproduce run the charms functional test for focal-victoria and then 'juju config ovn-dedicated-chassis source=cloud:focal-wallaby'. The charm should upgrade ovn-common and ovn-host packages but it does not.

Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

Triage: Set bug to high. I'm guessing it doesn't support action-managed-upgrades as that's a layer-openstack-principal which I don't think is included in the charm.

Changed in charm-ovn-dedicated-chassis:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Liam Young (gnuoy) wrote :

It seems to be because the initial install is done via the default_install method triggered from @reactive.when_not('charm.installed') which comes from layer-openstack. From then on the charm just does no have a handler that runs install and as ajkavanagh (and Bug #1902561) note, there is no action-managed-upgrade option

Liam Young (gnuoy)
Changed in charm-ovn-dedicated-chassis:
assignee: nobody → Liam Young (gnuoy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-ovn-dedicated-chassis (master)
Changed in charm-ovn-dedicated-chassis:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ovn-dedicated-chassis (master)

Reviewed: https://review.opendev.org/c/x/charm-ovn-dedicated-chassis/+/786659
Committed: https://opendev.org/x/charm-ovn-dedicated-chassis/commit/5061377d21b84101d60069894af9b43b3d6fc93f
Submitter: "Zuul (22348)"
Branch: master

commit 5061377d21b84101d60069894af9b43b3d6fc93f
Author: Liam Young <email address hidden>
Date: Fri Apr 16 13:47:52 2021 +0000

    Upgrade if source changes.

    Run package upgrade if source changes.

    Change-Id: I8d340c407b9f7a68f81da4886320e94a8850c4c0
    Closes-Bug: 1924596

Changed in charm-ovn-dedicated-chassis:
status: In Progress → Fix Committed
Changed in charm-ovn-dedicated-chassis:
milestone: none → 21.04
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.