Allow users to show/hide Angular grid menu entries

Bug #1923640 reported by Bill Erickson
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Evergreen 3.7 / Wishlist

Given the number of entries in the actions-for-selected-rows (<eg-grid-toolbar-action/>) Angular grid menus, it would be helpful if staff had the ability to hide (and re-show) selected menu entries.

The show/hide settings can live within the existing grid preferences structure, so no new workstation settings would be required.

The grid configuration menu would get a new action (e.g. Edit Actions Menu) that opens the menu in an editable format where users can select to show/hide individual entries.

Elaine Hardy (ehardy)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Bill Erickson (berick) wrote :

A branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1923640-ang-grid-menu-hide-entries-v1

From commit:

Adds a new Angular Grid configuration menu entry labeled "Manage Actions Menu", which launches a new dialog which allows staff to show/hide individual entries in the grid toolbar actions menu / context menu. The new menu action is disabled when a grid has no toolbar actions.

As with other Grid changes, the user must still click Save Grid Settings to persist the changes.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
tags: added: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

Just noting we deployed this locally to production and staff are very happy with it.

Erica Rohlfs (erohlfs)
Changed in evergreen:
assignee: nobody → Erica Rohlfs (erohlfs)
Revision history for this message
Erica Rohlfs (erohlfs) wrote :

The new Manage Actions Menu is nice and appears to be working. Much of the admin interface has either edit/delete actions. However, this feature is quite nice in tidying up the Holdings View of a bib record. I have tested this code and consent to signing off on it with my name, Erica Rohlfs and my email address, <email address hidden>.

Changed in evergreen:
assignee: Erica Rohlfs (erohlfs) → nobody
tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master for inclusion in 3.8. Thanks, Bill and Erica!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
Revision history for this message
Lindsay Stratton (lstratton) wrote :

Testing this in 3.8 and have found that the selections are not sticky. I would expect that selections would remain until deselected.

Using a staff account -

1 - opened Holds Pull List. From Manage Actions Menu, deselected all Item actions. The selections updated in the Actions menu. After refreshing the screen (and in a separate test closing the pull list and reopening it), the selections did not persist.

2 - opened an item record > holdings view. Deselected actions, changing the action options for that record. Performed another search, without closing or refreshing that tab, and the deselected actions reappeared in the menu.

Revision history for this message
Michele Morgan (mmorgan) wrote :

Lindsay,

I just tested this in 3.8.0 and it is working for me.

Thanks for providing your steps, I don't see that they include clicking 'Save Grid Settings', which is required to make the selections stick per Comment #1:

"As with other Grid changes, the user must still click Save Grid Settings to persist the changes."

Does that fix the issue?

Revision history for this message
Lindsay Stratton (lstratton) wrote :

Hi Michele,

D'Oh! Yeah, saving is always good, and solved all the problems. Good thing to note for training at least, that the behavior is *not* like other check/uncheck settings, such check in modifiers and similar toggles.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.