Tempest scenario test_write_data_to_share_created_from_snapshot is IP access only

[Tom Barron]

The test case:

manila_tempest_tests.tests.scenario.test_share_basic_ops.ShareBasicOpsBase.test_write_data_to_share_created_from_snapshot

creates a share and a user VM, mounts the share on the VM, writes a file to the share from the VM, snapshots the share, creates a second file in the share, and creates a new share from the snapshot.
It mounts the new share and verifies that the first file but not the second are present in the new share. It writes a third file to the new share that was created from snapshot, then verifies that this third file is present only in the new share, not in the original.

To achieve the read-write mounts to the user VM, RW access to the orignal and to the new share must be granted to the VM. This is achieved by invoking the provide_access_to_auxiliary_instance() method, defined in the ShareScenatioTest classat manila_tempest_tests/tests/scenario/manager_share.py.

This method is IP protocol specific and fails if the share uses an access protocol like native CephFS or CIFS instead of "ip."

[Tom Barron (tpb)]

There are other test cases that potentially suffer from this same issue but they appear to be skipped today for other reasons.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/785558
Committed: https://opendev.org/openstack/manila-tempest-plugin/commit/35091ce994050cd53ea288448d0fdfbe48462c8b
Submitter: "Zuul (22348)"
Branch: master

commit 35091ce994050cd53ea288448d0fdfbe48462c8b
Author: Goutham Pacha Ravi <email address hidden>
Date: Thu Apr 8 23:17:26 2021 -0700

    Reorganize scenario tests

    Create protocol specific manager classes
    where we can abstract away common code
    to handle access rules and mount operations
    and re-use these in the tests to get adequate
    coverage to the three protocols we support
    in these tests currently.

    Change-Id: I7e63434e745cc1c2a5e8aaccc20f7c31404742d9
    Closes-Bug: #1921369
    Signed-off-by: Goutham Pacha Ravi <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/786805

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Tom Barron <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/782947
Reason: Goutham is fixing the tests so that we don't need to skip.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/786805
Committed: https://opendev.org/openstack/manila-tempest-plugin/commit/602f101c14ea9130226359942636fb5bf0c9e782
Submitter: "Zuul (22348)"
Branch: master

commit 602f101c14ea9130226359942636fb5bf0c9e782
Author: Goutham Pacha Ravi <email address hidden>
Date: Sun Apr 18 16:25:25 2021 -0700

    Fix CephFS snapshot cloning scenario test

    When unmounting a share with the kernel
    client, the target directory must be what
    we used during the mount operation.

    This patch adds a create-share-from-snapshot
    scenario test for the ceph-fuse client, and
    drops the redundant 'ip_version' attribute
    to test classes that was added in the
    test reorganization patch earlier [1]

    [1] I7e63434e745cc1c2a5e8aaccc20f7c31404742d9
    Change-Id: I9e373c658bf8aefa5763b7bb58637969e5253312
    Closes-Bug: #1921369
    Signed-off-by: Goutham Pacha Ravi <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila-tempest-plugin train-last release.