Allow json lists to be passed in via the pci-alias charm config option so that multiple aliases can be set

Bug #1921147 reported by teluka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Nova Compute Charm
Fix Released
Undecided
Rodrigo Barbieri

Bug Description

Currently, the nova-compute charm doesn't support json lists to be passed via the pci-alias parameter.

https://github.com/openstack/charm-nova-compute/blob/stable/20.10/hooks/nova_compute_context.py#L279

Nova.conf already support multiple alias fields since the following PR https://review.opendev.org/c/openstack/nova/+/592243/ got merged.

Nova.conf ref https://docs.openstack.org/nova/latest/configuration/config.html#pci.alias

Json lists are supported by nova-cloud-controller charm already https://github.com/openstack/charm-nova-cloud-controller/blob/stable/20.10/hooks/nova_cc_context.py#L398

teluka (mateusz-p)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-nova-compute (master)
Changed in charm-nova-compute:
status: New → In Progress
Changed in charm-nova-compute:
assignee: nobody → Rodrigo Barbieri (rodrigo-barbieri2010)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-nova-compute (master)

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/795411
Committed: https://opendev.org/openstack/charm-nova-compute/commit/d51e010fcac6544775f95127c14f247532213d9b
Submitter: "Zuul (22348)"
Branch: master

commit d51e010fcac6544775f95127c14f247532213d9b
Author: Rodrigo Barbieri <email address hidden>
Date: Tue Jun 8 16:11:59 2021 -0300

    Port ncc pci-alias list fix to nova-compute

    Port of https://review.opendev.org/535350

    Fix for this bug already exists for
    nova-cloud-controller charm, therefore
    port it over to nova-compute.

    Closes-bug: #1921147
    Change-Id: I0c37d2bce3b195f5dc18111bb70a30de03b2bbc6
    func-test-pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/587

Changed in charm-nova-compute:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-nova-compute (stable/21.04)

Fix proposed to branch: stable/21.04
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/798288

Changed in charm-nova-compute:
milestone: none → 21.04
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-nova-compute (stable/21.04)

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/798288
Committed: https://opendev.org/openstack/charm-nova-compute/commit/09c51160203bd2d803b63d2edfd47418f2f613cd
Submitter: "Zuul (22348)"
Branch: stable/21.04

commit 09c51160203bd2d803b63d2edfd47418f2f613cd
Author: Rodrigo Barbieri <email address hidden>
Date: Tue Jun 8 16:11:59 2021 -0300

    Port ncc pci-alias list fix to nova-compute

    Port of https://review.opendev.org/535350

    Fix for this bug already exists for
    nova-cloud-controller charm, therefore
    port it over to nova-compute.

    Closes-bug: #1921147
    Change-Id: I0c37d2bce3b195f5dc18111bb70a30de03b2bbc6
    (cherry picked from commit d51e010fcac6544775f95127c14f247532213d9b)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.