Navigation buttons in staff client browse result appear untranslated

[Eva Cerninakova]

In Evergreen 3.6.2 in the Angular staff client, the navigation buttons "Next" and "Back" are displayed untranslated in the Browse and Shelf Browse result screen, see the attachment.

I am not sure where the strings come from, and also whether the strings have been marked for translation. In The POEditor translation strings I didn’t have found the "Back" string, however, there is the string Next (ID 3885497195825665706).

[Eva Cerninakova (ece)]

The problem i probably caused by code in lines 16 and 17 in Open-ILS/src/eg2/src/app/staff/nav.component.html.

I suppose the original lines 16 and 17
         <a ngbDropdownToggle i18n class="nav-link dropdown-toggle">
          Search

 should be replaced by following:
         <a ngbDropdownToggle class="nav-link dropdown-toggle">
          <span i18n>Search</span>

[Eva Cerninakova (ece)]

I accidentally mixed another two similar problems - the comment #2 concerns not the browsing navigation button, but the untranslated "Search" menu item on the main navigation bar.

The untranslatable "back" and "next" strings are in the template Open-ILS/src/eg2/src/app/staff/catalog/cnbrowse/results.component.html, lines 31 & 32, 79 & 80:

31       <button class="btn btn-primary" (click)="prevPage()">Back</button>
32       <button class="btn btn-primary ml-3" (click)="nextPage()">Next</button>

79       <button class="btn btn-primary" (click)="prevPage()">Back</button>
80       <button class="btn btn-primary ml-3" (click)="nextPage()">Next</button>

[Eva Cerninakova (ece)]

Still issue in Evergreen 3.11. Tested in https://bugsquash3.mobiusconsortium.org/

[Eva Cerninakova (ece)]

Still an issue. Tested on https://bugsquash3.mobiusconsortium.org/

[Linda Jansova (skolkova-s)]

I can confirm it is still an issue on Blake's bugsquash2 test server.

My guess is that adding the i18n attribute to the button element on lines 31, 32, 79 and 80 in the results.component.html file (https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/eg2/src/app/staff/catalog/cnbrowse/results.component.html;h=02dd920287fe57ebcee097bf7a50ee165eed37c1;hb=HEAD) which Eva has mentioned in comment #3 could serve an appropriate remedy.

[Stephanie Leary (stephanieleary)]

Thanks for tracking down the exact lines, Linda!

Here's a branch that adds the missing i18n attributes (with clarification for translators): https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/LP1920247-missing-nav-button-i18n

[Linda Jansova (skolkova-s)]

Thank you very much, Stephanie!

[Mike Rylander (mrylander)]

Picked to main, I18N FTW! Also, more examples of providing translator context! Thanks, Stephanie.