[sync-request] Please sync alexandria 0.6.2 from the alexandria-team PPA

[Lennart Karssen]

Binary package hint: alexandria

I just noticed that the alexandria package in Hardy is still version 0.6.1. Version 0.6.2 is out and contains a lot of bugfixes. Packages (including dependencies) for Hardy are available in the alexandria-team PPA at https://launchpad.net/~alexandria-team/+archive.

[SK (stephantom)]

Thank you for taking the time to report this issue and helping to improve Ubuntu!
In order to get a package synced you need to follow the steps outlined in https://wiki.ubuntu.com/SyncRequestProcess – I have completed most of the process for you now.
Note that we have the FeatureFreeze today, so you need to provide a changelog relative to the current version in the repositories.

[Joseph Method (tristil)]

PPA repository: https://launchpad.net/~alexandria-team/+archive
source package: alexandria 0.6.2 taken from http://alexandria.rubyforge.org/svn/trunk/alexandria r904 (can be considered 0.6.2.1)

No known Ubuntu changes. Any Ubuntu changes should be overridden.

* Added man page
* Improved manual
* Significant stability improvements.
* Adds Smart Libraries which are filtered views on your libraries.
* New support for tagging books and filtering on tags.
* New multi-input method for CueCat barcode scanners.
* Book data attributes for owning, having read, wanting, last read date

* Bugs fixed post 0.6.2

#17437 Context right-click on library shouldn't wait for library to load
#17192 Please remove "Encoding" from desktop file
#17191 Website download link points to 0.6.2b2...
#16855 *** glibc detected *** corrupted double-linked list: 0x...
#16853 When looking for book cover, doesn't recognise HTML error page from adlibris.se
#16743 Entered ISBN whole screen turned grey and dialogue box did not respond for minutes
#16733 A book that was deleted and then re-added to a library is not stored
#16728 0.6.2 does not start, perhaps due related to ruby/Revolution
#16708 Hitting refresh button makes deleted books reappear
#16699 Default smart libraries are not translated
#16680 mauvais affichage des caractéres accentués
#16647 Latest translaters aren't listed in the About dialog
#16633 Affiche de caractères accentués ne fonctionan pas correctement
#16618 When you go back into properties program removes read it tag
#16614 Loses details when using ISBN search
#16611 Entered true ISBN number and got a giberish book back
#16567 Add a book the button is grayed out
#16557 Close Button on About Dialogue
#16541 Tends to Freeze

* Many bugs fixed since 0.6.1 including these in Rubyforge tracker:
    #2518 #2533 #3130 #5911 #6742 #8173 #8719 #9545 #13482 #11170
    #11306 #14164 #1423 #14592 #15510 #15924 #16355 #16356 (for full list with descriptions, see attachment)

[SK (stephantom)]

Thank you! That should be everything that is required to synch the package.

[Daniel Holbach (dholbach)]

Lots of changes have been made in the packaging:
 - dropped changelog entries,
 - changed maintainer
 - added generated postinst/postrm/prerm?
 - dropped watch file, dropped menu file, dropped manpage.

[Siegfried Gevatter (rainct)]

Please address Daniel's concerns and subscribe motu-release for them to approve this upload, as there is now Feature Freeze for Hardy. Once they give their approval, subscribe ubuntu-universe-sponsors again.

Thanks.

[Lennart Karssen (l.c.karssen)]

Daniel,
Thanks for your input on the sync-request. However, I'm not sure what
you want to say with your comment. I assume that these are your
observations and you want them to be taken into account when deciding
whether or not to perform the sync? Or is there some action to be taken
by us?
(I tried replying to launchpad's bug report e-mail, but apparently that didn't end up here).

Siegfried,
Looking at your first sentence I wonder whether subscribing motu-release can be done now, or do we have to address Daniel's concerns first before doing so?

[Siegfried Gevatter (rainct)]

Please address Daniel's concerns first.

[Siegfried Gevatter (rainct)]

Please address Daniel's concerns first.

[Joseph Method (tristil)]

Does it help to say that the packaging has been taken over by the project maintainers, since the old maintainer left? And that the debian directory is integrated into svn now?

Responding to Daniel Holbach:
Lots of changes have been made in the packaging:
 - dropped changelog entries,
   We switched to an automatic read-out of `svn log`.
 - changed maintainer
   As mentioned the old maintainer left, but now the project leads are the packagers.
 - added generated postinst/postrm/prerm?
    Yes, we did a one-time generation of postinst/postrm/prerm. Is this against policy?
 - dropped watch file, dropped menu file, dropped manpage
   There is a manpage in the package. We think that menu files are possibly deprecated? And added watch file to r905.

We plan to release 0.6.3 immediately, to clean out our numbers, and we'll make a new package off that. But we need to know: what changes _must_ be made, what changes are optional, and can we still go forward with a sync during this cycle, or are the MOTUs opposed?

[Siegfried Gevatter (rainct)]

Menu files are still widely used (by most Debian users, those Ubuntu
users who prefer Debian's menu, Ubuntu user's that use Openbox, etc).
They are a "should" in the policy, but please add it back.

[Lennart Karssen (l.c.karssen)]

Alexandria 0.6.3 has been released (also to ppa).

Major bugs fixed in this release:
- [#14163] Newly added book is not selected
- [#16708] Hitting refresh button makes deleted books reappear
- [#16619] When searching by isbn misses information
- [#16618] When you go back into properties program removes read it tag
- [#15329] Using & in library name is impossible
- [#14592] Fails to start: undefined method 'isbn'
- [#18197] Setting book rating through right-click menu causes crash
- [#13302] Fails with z39.50 providers which don't support 'piggybacking'

Furthermore, this release has updated Amazon compatibility with ECS 4.0 as Amazon's AWS 3.x will be deprecated by Amazon on March 31 2008.

Please inspect this package and tells us which things still need to be ironed out if we want to stand a chance for inclusion in Hardy Universe.
Thanks.

[Joseph Method (tristil)]

Please note this package has a watch file and a menu file.

[Lennart Karssen (l.c.karssen)]

Since Daniel H's concerns are now addressed I've subscribed motu-release to this bug in order to get approval (as per Siegfried's instructions).

[Scott Kitterman (kitterman)]

Freeze exception needs the following information (see the Universe section):

https://wiki.ubuntu.com/FreezeExceptionProcess

[Scott Kitterman (kitterman)]

At this point in the process (getting close to beta) I would feel a lot more comfortable with a new upstream release based on the Debian Maintainer's packaging than on redo it. Please release your upstream tarball without a debian dir in it and then make an appropriate package for Debian/Ubuntu based on the existing packaging.

Also, we don't sync from PPAs and the versioning of your current PPA version would be totally inappropriate for sync into Ubuntu if we did. At a quick review your packaging would work to be brought up to a standard to be appropriate for inclusion in Ubuntu.

[Scott Kitterman (kitterman)]

Also please leave the status as New/Incomplete until it's approved. Someone from motu-release will set it to confirmed if it's approved.

[Lennart Karssen (l.c.karssen)]

Unfortunately we could not get an update of the Debian package in time for Hardy. Our new goal is to go for the next Ubuntu release by trying to get the Debian package updated. Therefore I guess this request can be closed.

By the way, https://bugs.launchpad.net/ubuntu/+source/alexandria/+bug/199565 is a duplicate of this bug.

[Scott Kitterman (kitterman)]

If you can make a 0.6.2 package based on Debian and attach the .diff.gz here it can still be considered.

[Joseph Method (tristil)]

Here's a diff.gz based on the 0.6.1 package available in Ubuntu. Please note it's now at 0.6.3, and is versioned as a Debian package.

[Scott Kitterman (kitterman)]

Ack from me.

[Lennart Karssen (l.c.karssen)]

Following Siegfried's instructions I've subscribed ubuntu-universe-sponsors now that we have an approval from motu-release.

[StefanPotyra (sistpoty)]

ACK #2, please go ahead.

[Emilio Pozuelo Monfort (pochu)]

Lennart,

Your diff.gz version has a wrong target (unstable vs hardy) and a wrong version (0.6.3 vs 0.6.3-0ubuntu1). Can you attach a good one?

[Lennart Karssen (l.c.karssen)]

Joseph, could you please take care of the diff.gz? My Debian packaging skills are non-existent :-).

Thanks!

[Joseph Method (tristil)]

diff.gz attached.

[Emilio Pozuelo Monfort (pochu)]

What about these files added / patched by your diff.gz?

patching file lib/alexandria/config.rb
patching file lib/alexandria/default_preferences.rb
patching file data/omf/alexandria/alexandria-fr.omf
patching file data/omf/alexandria/alexandria-C.omf
patching file tasks.rb

[Joseph Method (tristil)]

Good catch. I can clean these up in subsequent packaging, but there are no issues here, I can confirm. All of these are necessary generated products that aren't in the source package.

[Emilio Pozuelo Monfort (pochu)]

Can you please explain me:
- the rationale for your changes to debian/rules
- why upstream installs files in debian/, and why the build will fail if those files aren't present

Here's is a debdiff for the 0.6.1->0.6.3 update. It won't work for upstream trying to install those mentioned files, but that's seems wrong to me.
I've also modified the debian/changelog entry to explain the changes. You should always explain every change you do.
And the debian version should have been 0.6.3-0ubuntu1, where 0.6.3 is the upstream version, -0 is the debian revision, and ubuntu1 is the ubuntu revision.

[Joseph Method (tristil)]

- One of the project admins wrote a custom rake based installer which displaced the extconf.rb based approach. Somewhere in the install code it's hardwired to install to debian if it's installing for a package.
- We were told we had to use debtools and it seems they assume alexandria/

I can make changes to upstream (I am also a project admin), but I'm reluctant because of approaching featurefreeze.

[Emilio Pozuelo Monfort (pochu)]

preinst/postinst/prerm are autogenerated from debhelper, so they shouldn't be in the debs.
I don't install what's the purpose of that (upstream installing the deb files to make life easier, instead of leaving those tasks to the debian packaging).

And regarding debian/rules, do you mean that everything that was done with ruby before is now done with rake?
+ rake debian\:deb_files
+ mv debian/tmp debian/alexandria

I'm not experienced with Ruby and Ruby packaging, so I don't want to upload alexandria this late in the cycle unless I'm confident and happy with the update.
If there's a MOTU reading this who can take care of this, we could get this in. FinalFreeze is this Thursday...

[Joseph Method (tristil)]

"And regarding debian/rules, do you mean that everything that was done with ruby before is now done with rake?"

Yes.

[Joseph Method (tristil)]

Sorry, and rake is a ruby tool that's included in the build requirements. extconf.rb is a monolithic ruby install script.

[Emilio Pozuelo Monfort (pochu)]

Ok, debian/rules change are fine. But I won't upload this shipping the
preinst/prerm/postinst, and without them the build fails.

So you can either find someone else who will upload it, convince me why they are
fine there, or fix it.

[Joseph Method (tristil)]

In this diff.gz postinst, postinst, prerm are removed. Version number has the -0 debian revision number. Changelog is more descriptive. Redundant steps taken by the installer have been commented out.

[Joseph Method (tristil)]

I take it today is the last day anything can be uploaded? I've done everything I've been asked to do. Please upload, or you'll be shipping with a mostly broken Alexandria.

[Emilio Pozuelo Monfort (pochu)]

Sorry, I forgot about this...

patching file lib/alexandria/config.rb
patching file lib/alexandria/default_preferences.rb
patching file data/omf/alexandria/alexandria-fr.omf
patching file data/omf/alexandria/alexandria-C.omf

I've removed those from the diff.gz... at least the last two are likely because an imcomplete upstream clean target.

[Scott Kitterman (kitterman)]

I'm not in a position to sponsor this, but would encouage someone to do so.
 At this point fix what you need to and upload it. Upstream has put a lot
of effort into this.

[Emilio Pozuelo Monfort (pochu)]

I've just uploaded it... it's "Pending approval" though.

Waiting for approval:
 OK: alexandria_0.6.3.orig.tar.gz
 OK: alexandria_0.6.3-0ubuntu1.diff.gz
 OK: alexandria_0.6.3-0ubuntu1.dsc
     -> Component: universe Section: interpreters
This upload awaits approval by a distro manager

[Lennart Karssen (l.c.karssen)]

Thanks Emilio!

[Scott Kitterman (kitterman)]

motu-release ack in case the earlier comment was unclear.

[Joseph Method (tristil)]

Thanks, Emilio! What has to happen to get the upload approved?

[Launchpad Janitor (janitor)]

This bug was fixed in the package alexandria - 0.6.3-0ubuntu1

---------------
alexandria (0.6.3-0ubuntu1) hardy; urgency=low

  * New upstream release, with freeze exception (LP: #191905).
  * Update for hardy
  * Moved to rake-based installation method
  * Commented out code that prevents installing package to debian directory
  * debian/tmp files are moved to debian/alexandria in rules
  * Change maintainer to Ubuntu MOTU Developers.

 -- Joseph Method <email address hidden> Mon, 07 Apr 2008 22:46:00 -0400

[Emilio Pozuelo Monfort (pochu)]

Joseph Method wrote:
> Thanks, Emilio! What has to happen to get the upload approved?
>

It's already in. My apologies for waiting till the last second to upload it, it
wasn't intentionally.

[Scott Kitterman (kitterman)]

Now that that's done I would strongly urge alexandria's developers to get
in touch with the Debian maintainer and work on getting updated there.

Debian is a much more natural source of package updates for us than a ppa.

[Lennart Karssen (l.c.karssen)]

Scott and Emilio (and all other who have helped us out),

Thanks for your work and support! We're glad that Alexandria 0.6.3 is now part of Ubuntu Hardy.
Daffyd Harries, the Debian maintainer of the Alexandria package used to be a developer for Alexandria too. We've already contacted him to work on better integration into Debian.

[Joseph Method (tristil)]

This is a bit desperate, but any chance that the package can be improved with the attached debdiff? This will make a very significant improvement to the end-user experience and avoid numerous bug complaints. The changes are:

+ * Add libruby-hpricot dependency -- otherwise the Amazon provider which handles the main functionality doesn't work out of the box.
+ * Change order of Amazon provider (fixed upstream) -- so that Amazon will be searched first
+ * Fix crashing bug with tooltips -- if a piece of metadata was missing the program would crash when user moused over the affected book

My sincere apologies for waiting so long; I had thought FinalFreeze was absolute and was focused on making a package for inclusion in ubuntu-backports. Again, these changes will make a huge difference, especially in light of the LTS. I promise that in the future Alexandria project will be on time and contribute through upstream Debian :)

[Emilio Pozuelo Monfort (pochu)]

This needs approval from ~motu-release.

Joseph, next time it's better to file a new bug report, so that it's easier to track its status (this bug was already closed). Perhaps you could create a new one and subscribe ~motu-release, so that it's on their bug list (as this one is fixed and won't show up there).

[Scott Kitterman (kitterman)]

Seems OK. Ack for motu-release, but I didn't look at the debdiff, so
sponsor review still needed.

[Emilio Pozuelo Monfort (pochu)]

Uploaded, thanks.

[Launchpad Janitor (janitor)]

This bug was fixed in the package alexandria - 0.6.3-0ubuntu2

---------------
alexandria (0.6.3-0ubuntu2) hardy; urgency=low

  * More bug fixes, LP: #191905.
  * Add libruby-hpricot dependency
  * Change order of Amazon provider (fixed upstream)
  * Fix crashing bug with tooltips

 -- Joseph Method <email address hidden> Tue, 15 Apr 2008 11:54:14 -0400