Share server limits forces shares from snapshots to be created in another share server

[Carlos Eduardo]

Description
===========
The share server limits feature proposed in [1] brings up an odd behavior for some backends.

Steps to reproduce
==================

* Set a share server limit 1 in the backend
* Create a share
* Create a snapshot
* Request to create a share from a snapshot

Expected result
===============
Some backends expect that the parent share server do not get removed from the reusable share servers list, considering that they must reuse the share server to create the share from the snapshot.

Actual result
=============
The share server is being removed from the available share servers list, and manila is forcing new share servers to be created. This makes the snapshot which the share is being created upon to be placed in another share server, and the share creation fails, since for some backends it must have the snapshot and the share (which is being created) placed in the same share server.

References
==========
[1] https://review.opendev.org/c/openstack/manila/+/762725

[Goutham Pacha Ravi (gouthamr)]

Carlos, we're closing on xena-RC1 soon.

i'm moving this bug to Yoga-1; please let me know if that timeline is inaccurate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/857628

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/857628
Committed: https://opendev.org/openstack/manila/commit/3bd8fe3cfe5f9e9bffb18f0a6ae669bc83c1c665
Submitter: "Zuul (22348)"
Branch: master

commit 3bd8fe3cfe5f9e9bffb18f0a6ae669bc83c1c665
Author: Felipe Rodrigues <email address hidden>
Date: Wed Sep 14 23:31:09 2022 -0300

    Fix Create From Snapshot with Server Limits

    Share Server limits must be ignored in case the new share is
    from a snapshot and same host as the parent, since they must
    be in the same server.

    Closes-bug: #1918845
    Change-Id: I1c611f4a7f3590b571f75ceca17c2fc3d8f3ad7a

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 15.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/manila/+/863272

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/863272
Committed: https://opendev.org/openstack/manila/commit/ba1fa6522fecfb84ea4a3ea334aa052a4a22df26
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit ba1fa6522fecfb84ea4a3ea334aa052a4a22df26
Author: Felipe Rodrigues <email address hidden>
Date: Wed Sep 14 23:31:09 2022 -0300

    Fix Create From Snapshot with Server Limits

    Share Server limits must be ignored in case the new share is
    from a snapshot and same host as the parent, since they must
    be in the same server.

    Closes-bug: #1918845
    Change-Id: I1c611f4a7f3590b571f75ceca17c2fc3d8f3ad7a
    (cherry picked from commit 3bd8fe3cfe5f9e9bffb18f0a6ae669bc83c1c665)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 14.0.1 release.