CGI params starting with "copy" cause problems

[Mike Rylander]

In recent browsers, it seems that a CGI parameter that starts with "copy" and is not the first parameter, and is therefore preceded by an ampersand, is translated to a copyright character when the browser sends the URL to the server. This is ungood.

Forthcoming is a branch that changes the "copy" portion of copy_limit, copy_offset, copy_depth, and copy_id to "cp" instead. Only the templates (which generate and read the parameters) and two mod_perl modules (which read the parameters) are changed.

[Mike Rylander (mrylander)]

Branch available here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1917951-rename-copy_blah-cgi-params

[Jason Boyer (jboyer)]

Mike, where are you seeing this happening? This should have gotten significantly better with the closing of bug 1914116 but if there are other places it's popping up the right fix is likely sprinkling some more "| html" (or similar) about.

[Jason Stephenson (jstephenson)]

The code from bug 1687545 was reverted in an attempt to address this issue.

Can someone please confirm if that did, indeed, address this problem.

[Jason Boyer (jboyer)]

Reverting 1687545 did indeed fix this issue; marking bug invalid as the correct fix to bug 1687545 would html-encode these parameters anyway, avoiding this problem.