Angular Staff Catalog: Hold Pickup Library sometimes empty

[Terran McCanna]

Since we upgraded to Evergreen 3.6.1:

When staff place a hold for a patron, the pickup library does not always populate. By comparing accounts, I believe this is a problem of no value vs empty value.

- When placing a hold for a patron who has never had a default pickup library set, the pickup library dropdown correctly falls back to the patron's home library. All good there.

- However, when placing a hold for a patron who has a default pickup library set to "", the pickup library dropdown does not populate. (Screenshot attached.)

Unfortunately, this is a difficult error to recreate with Concerto data because the patron interface will no longer allow you to delete a default pickup library once one has been set (if you erase it and save the account, it keeps the previous value). So, I think this is only a bug that will be seen with existing patron that has gone through an upgrade.

[Garry Collum (gcollum)]

I checked our test database (3.6.2) which is a copy of our 3.4 production data. Confirming that this behavior is caused by "" being the value of opac.default_pickup_location in the usr_setting table.

[Garry Collum (gcollum)]

A proposed fix is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/LP1917944-Hold_pickup_library_sometimes_blank

[Michele Morgan (mmorgan)]

This works great! With the patch in place, the pickup location is properly filled in when a staff user places a hold for a patron with opac.default_pickup_location of ""

The pickup library also properly defaults to the workstation ou if circ.staff_placed_holds_fallback_to_ws_ou is set to TRUE for the library.

My signoff branch is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=94d3609baf338ead2ff26a1f29384a70dcccc33e

[Galen Charlton (gmc)]

Pushed down to rel_3_6 along with a follow-up to make ng lint happy. Thanks, Garry and Michele!