QT_SCREEN_SCALE_FACTORS causes CUE marker display misplacement

[Attila Schler]

Setting QT_SCREEN_SCALE_FACTORS causes CUE marker display misplacement on waveforms

See on the screenshots in the attached pdf:
QT_SCREEN_SCALE_FACTORS_AND_CUE_MISPLACEMENT.PDF

Mixxx 2.3.0-beta (build 2.3 r8043)
Operating System: openSUSE Tumbleweed 20210220
Qt Version: 5.15.2
Kernel Version: 5.10.16-1-default
Graphics Processor: Mesa DRI Intel® HD Graphics 3000

[Attila Schler (atskler)]

Should I re-report this bug under launchpad.net/mixxx/2.3 ?

[Jan Holthuis (holthuis-jan)]

No, I just changed the milestone.

[Owen Williams (ywwg)]

Yeah I've seen this on windows

[Attila Schler (atskler)]

I would like to ask if this bug will be fixed for the 2.3 release?

[ronso0 (ronso0)]

Very unlikely because we're about to release 2.3 atm

[Attila Schler (atskler)]

Important, so please note it is not just the CUE label, but the complete marker is misplaced on the display. If you jump to a cue, mix will jump to it and will play from it, but the marker will not show the correct position.

.

I would like to add that this bug – at least for me – is quite frustrating, because on my notebook with its standard resolution everything is too small for using mixxx on a live gig: checking the display from about 80-100 cm distance.

Surely I can work around this problem with decreasing the screen resolution.

I think this feature would be important for others, and this problem can impact and mislead others already using this feature - regarding the displayed and the actual cue position.

[ronso0 (ronso0)]

sorry, my bad, I was confuding the play position with the Cue marker.

[ronso0 (ronso0)]

All waveform markers are affected.
Though there's a difference for text labels and those with icons:
TEXT:
 * text area is cropped
 * stroke is shifted right
  (the longer the text, the further it's shifted)
 * stroke is not painted top to bottom, but stops at
  (top-bottom)/scale factor, so for scale factor of 1.5 it's only
  the upper 2/3 that's painted
ICON:
 * entire icon is painted
 * stroke is shifted slightly (about half the icon width in Deere),
   though that differs for the CUE and loop_in icon

A wild guess: somwehere in the marker position calculation there's a rounding issues, and appearantly the scale factor is not considered correctly (incomplete stroke for text labels)

[ronso0 (ronso0)]

the marker text size is not scaled at all...

got it!

[ronso0 (ronso0)]

https://github.com/mixxxdj/mixxx/pull/3936

[ronso0 (ronso0)]

okay, that was easier than I though.
please test!

[Attila Schler (atskler)]

Thank you! I will test it once it is merged.

[ronso0 (ronso0)]

We prefer testing before merging changes ;)
For each PR there are test builds for Linux, Win and mac (artifacts).
see https://github.com/mixxxdj/mixxx/wiki/Testing for details, especially the backup part.

[ronso0 (ronso0)]

and the fix for pixmap icons
https://github.com/mixxxdj/mixxx/pull/3938

[Attila Schler (atskler)]

Thank You for fixing this issue for v2.3!

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10335