Nextcloud settings window does not get decorated with window control buttons

[Neil McPhail]

Ubuntu Mate 21.04 daily build fresh install today. Selected "Redmond" layout. Installed nextcloud-desktop and connected to my server. Clicked on the nextcloud icon in the panel and selected "settings".

What should happen:
- Nextcloud settings app should appear with close/minimise/restore buttons

What actually happens:
- Nextcloud settings app appears without these buttons. Has to be closed via the task list on the dock.

mate-window-applets-common 20.04.0-1
nextcloud-desktop 3.1.1-1

ProblemType: Bug
DistroRelease: Ubuntu 21.04
Package: mate-window-applets-common 20.04.0-1
ProcVersionSignature: Ubuntu 5.10.0-14.15-generic 5.10.11
Uname: Linux 5.10.0-14-generic x86_64
ApportVersion: 2.20.11-0ubuntu59
Architecture: amd64
CasperMD5CheckResult: unknown
CurrentDesktop: MATE
Date: Sat Feb 27 23:46:33 2021
InstallationDate: Installed on 2021-02-27 (0 days ago)
InstallationMedia: Ubuntu-MATE 21.04 "Hirsute Hippo" - Alpha amd64 (20210227)
PackageArchitecture: all
SourcePackage: mate-window-applets
UpgradeStatus: No upgrade log present (probably fresh install)

[Neil McPhail (njmcphail)]

Exploring further, this issue happens with the default theme (which is Yaru-MATE-Light, I think) but not with Ambient-MATE, where the "Close" button displays correctly.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Martin Wimpress  (flexiondotorg)]

The Next Cloud declares its windows as modal.

_NET_WM_STATE(ATOM) = _NET_WM_STATE_MODAL

This is a little unusual, since modals should be used for dialog boxes. That said, the Yaru Metacity theme set the geometry for modal windows as having no buttons.

I will re-instate the window buttons for modal windows in Yaru.

[Martin Wimpress  (flexiondotorg)]

Starting with Ubuntu MATE 22.04 the Metacity themes come from upstream Yaru, which is why ubuntu-mate-artwork is no longer a valid candidate.

[Martin Wimpress  (flexiondotorg)]

Pull request submitted:

- https://github.com/ubuntu/yaru/pull/3557

[Launchpad Janitor (janitor)]

This bug was fixed in the package yaru-theme - 22.04.3.1

---------------
yaru-theme (22.04.3.1) jammy; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * gtk: Do not use shell scss sources to define accent colors used by icons
  * github: Generate rendered icons and symlinks automatically
  * icons: Use more predicibile rendering target names
  * meson: Render each icon separately to use multi-process rendering
  * render-bitmaps: Fail in case no SVG is rendered
  * meson: Allow to render one icon across all the flavours separately
  * render-bitmaps: Support searching for icons by category
  * github: Add automated workflow to optimize SVG
  * github: Do a full icons rebuild if the renderer script changes
  * icons/generate-symlinks.sh: Ignore empty lines on list file
  * icons/phosh.list: Remove trailing empty line
  * CI: Split build workflow in multiple steps
  * icons: Add tests to try generating symlinks
  * meson: Use more fs filename modifications functions
  * Revert "icons: modify meson and deb files (LP: #1965649)
  * github: Fix Links on generated PRs
  * meson: Bump dependency to 0.59 as per fs.parent() usage
  * icons: Install panel icons only if mate or unity are enabled
  * icons: Ensure symlinks are all generated from symlink script
  * icons/scalable: Remove icons that are already handled via symlinks
  * icons: Remove all the links in source dirs, they should be handled via lists
  * CI: Recreate symlinks removing old ones
  * CI: Detect changes on all symlinks files
  * CI: Ensure that no symlinks are used in icon sources
  * CI: Use inverse logic, we don't want symlinks :)
  * CI: Cleanup rendered icons before render them again
  * icons/accented: Remove software store from accented icons
  * gnome-shell: Use correct syntax for or'ed find
  * CI: Archive meson logs
  * generate-index-theme: Support excluding a specific icons directory
  * icons: Also generate symlinks for 22x22 icons
  * icons: Generate panel symlinks, and install them only when needed
  * generate-index-theme: Handle the scalable min/max size cases
  * generate-index-theme: Use proper context names when not computable
  * icons: Auto-generate index.theme for default and mate icon themes
  * generate-index-theme: Support excluding elements by context
  * generate-index-theme: Support providing custom parameters for a folder
  * icons: Replicate symlinks in installed folder when using meson >= 0.61
  * icons: Use nicer way to compute find command for excluded folders
  * gnome-shell: Use native meson symlink installer when possible
  * icons, gnome-shell: Use python-computed relative paths
  * CI: Make meson options more readable in full build
  * gnome-shell: Add further option to toggle UserThemes support
  * debian/rules: Enable user themes support in packages
  * icons: Add more accented icons
  * icons: Use better name for rendered icon target
  * gtk, gnome-shell: Only generate Yaru-$accent-dark themes if `dark` is set
  * icons: Generate dark variants of the icons theme
  * CI: Also consider untracked changes on rendering/optimizing icons
  * CI: Use proper syntax to check on rendered icons changes
  * icons: Install icons symlinks as such also wit...