Regression issue with external-global-acpi_update.dpatch - detecting C2/C3 states for systems without CST
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux-source-2.6.15 (Ubuntu) |
Fix Released
|
Medium
|
Fabio Massimo Di Nitto |
Bug Description
The respective acpi-update has a regression issue with detecting C2/C3 states
for systems without CST. Either pull in an updated version from the ACPI-tree or
apply the patch below. With the current dpatch C2/C3 states stop working on some
laptops. Actually, pulling in patches and not even given the status or time of
the pull in the patch (see DP-lines) is a quite risky approach. Ubuntu-breezy
should not be a regression-
=======
From: Jindrich Makovicka
<email address hidden>
Re-enable C2/C3 states for systems without CST. Fixes a regression after
the patch for C2/C3 support for multiprocessors
(http://
the acpi_processor_
Signed-off-by: Jindrich Makovicka
<email address hidden>
Cc: "Brown, Len" <email address hidden>
Signed-off-by: Andrew Morton <email address hidden>
---
drivers/
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN
drivers/
drivers/
---
devel/drivers/
2005-07-14 15:53:47.000000000 -0700
+++ devel-akpm/
@@ -881,7 +881,7 @@ static int acpi_processor_
result = acpi_processor_
if ((result) || (acpi_processor
result = acpi_processor_
- if (result)
+ if ((result) || acpi_processor_
result = acpi_processor_
}
_
(In reply to comment #0)
> The respective acpi-update has a regression issue with detecting C2/C3 states
> for systems without CST. Either pull in an updated version from the ACPI-tree or
> apply the patch below. With the current dpatch C2/C3 states stop working on some
> laptops.
Matthew what do you prefer? this patch or to give me new acpi crack?
>Actually, pulling in patches and not even given the status or time of repository for acpi-patches, IMHO.
> the pull in the patch (see DP-lines) is a quite risky approach. Ubuntu-breezy
> should not be a regression-
>
DP lines are at maintainer discrection. Matthew is our acpi guru and he keeps
track of what is what and when. Also breezy is a development branch. Breakage
and regression are expected and we are ready to fix them. Thanks for your
report and work.
Fabio