max_check_attempts None

[David O Neill]

Charm shouldn't put in None for max_check_attempts.
Give it a default possibly?

define service {
  use generic-service
  check_command check_nrpe_H_HOSTADDRESS__ccheck_megacli_t15!
  host_name bootstack-pccw-malawi-CTR02
  service_description bootstack-pccw-malawi-CTR02-megacli
  max_check_attempts None
}

Error: Invalid max_attempts, check_interval, retry_interval, or notification_interval value for service 'bootstack-pccw-malawi-CTR01-ipmi' on host 'bootstack-pccw-malawi-CTR01'
Error: Could not register service (config file '/etc/nagios3/conf.d/charm.cfg', starting on line 6452)
   Error processing object config files!

***> One or more problems was encountered while processing the config files...

     Check your configuration file(s) to ensure that they contain valid
     directives and data defintions. If you are upgrading from a previous
     version of Nagios, you should be aware that some variables/definitions
     may have been removed or modified in this version. Make sure to read
     the HTML documentation regarding the config files, as well as the
     'Whats New' section to find out what has changed.

sed '/max_check_attempts None/d' -i /etc/nagios3/conf.d/charm.cfg

[Drew Freiberger (afreiberger)]

I "think" this may be fixed in cs:nagios-42. To be verified.

[Linda Guo (lihuiguo)]

This defect should be fixed by below charm-helpers PR

https://github.com/juju/charm-helpers/pull/565/files

[Diko Parvanov (dparv)]

This has been fixed in commit a023e2f51901d9964e1327023bf44adbc53c011c, released in charm-nagios revision 42 onward.