Opt-in setting for overdue/predue emails

Bug #1915219 reported by Jeff Davis
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

It would be nice if there were a standard user setting that allowed users to opt out of receiving email notifications about overdue items, so that libraries don't spam their patrons with unwanted emails.

Action trigger opt-in settings make this very easy to implement -- in fact, we've had a setting like this in place for years at Sitka, and I imagine we're not the only ones. I'll share a version of what we're doing. All that's needed is to define a user setting and then set it as the opt_in_setting for the relevant a/t event definitions.

summary: - Opt-in settings for overdue/predue emails
+ Opt-in setting for overdue/predue emails
Changed in evergreen:
importance: Undecided → Wishlist
assignee: nobody → Jeff Davis (jdavis-sitka)
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp1915219-overdue-email-opt-in-setting has an implementation:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1915219-overdue-email-opt-in-setting

tags: added: actiontrigger pullrequest
Changed in evergreen:
milestone: none → 3.7-beta
assignee: Jeff Davis (jdavis-sitka) → nobody
Revision history for this message
Garry Collum (gcollum) wrote :

Jeff. This would be a nice feature, and could be easily extended to SMS, as well.

In your instructions for the event_definition the query reads "opac.default_circ_notices_enabled" instead of "circ.default_overdue_notices_enabled".

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Whoops! Thanks for catching that, Garry. I have force-pushed a fix to the same branch, so the correct setting name should be used everywhere.

Revision history for this message
Garry Collum (gcollum) wrote :

Hi Jeff,

I get a foreign key constraint error when I test the seed-values file. '(grp)=(circ) is not present in table "settings_group"'.

It looks like the config.settings_group values are defined right after your code to insert the usr_setting_type.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Sheesh. Thanks again, Garry. I've pushed an additional commit that removes the (nonexistent) settings group from the user setting, consistent with most other such settings. I've also confirmed that the seed data actually gets loaded correctly now.

Revision history for this message
Garry Collum (gcollum) wrote :
tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master for inclusion in 3.7. Thanks, Jeff and Garry!

Galen Charlton (gmc)
Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.