build-img fails if not run under $MY_WORKSPACE

[Scott Little]

Brief Description
-----------------
build-img fails if run from any directory other than $MY_WORKSPACE

Severity
--------
Minor

Steps to Reproduce
------------------
cd $MY_REPO
build-img

Expected Behavior
------------------
a qcow is create

Actual Behavior
----------------
command fails

Reproducibility
---------------
100%

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
Jan 21 2021
Commit 287288c7c6c38c1dde16f89bbf7f73d9ea9e7bf3 vs root.git

Last Pass
---------
Jan 20 2021

Timestamp/Logs
--------------
...
Patch is /var/lib/jenkins/workspace/WRCP_Dev_QCOW/PATCH.img-addon.patch
patch-iso -i /tmp/build_img.mUUzD9kw/bootimage_aio_graphical.iso -o /tmp/build_img.mUUzD9kw/bootimage_aio_graphical_patched.iso /localdisk/loadbuild/jenkins/WRCP_Dev_Build/2021-02-09_00-28-00/PATCH.img-addon.patch
Patch file /localdisk/loadbuild/jenkins/WRCP_Dev_Build/2021-02-09_00-28-00/PATCH.img-addon.patch does not exist

Test Activity
-------------
Build

Workaround
----------
'cd $MY_WORKSPACE' prior to 'build-img'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/root/+/786137

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/root/+/786137
Committed: https://opendev.org/starlingx/root/commit/0ce0a1e5e3c5318a9a530c1d5ad90a7e19755a45
Submitter: "Zuul (22348)"
Branch: f/centos8

commit 0ce0a1e5e3c5318a9a530c1d5ad90a7e19755a45
Author: Scott Little <email address hidden>
Date: Tue Feb 9 13:12:06 2021 -0500

    build-img fails if not run under $MY_WORKSPACE

    Build-img may need to generate a patch that is to be applied to the
    image being produced. The patch build tool drops the patch into
    the current directory. No explicit working directory was set.
    A subsequent step tries to apply the patch, but assumes it is in
    $MY_WORKSPACE.

    We want all build artifacts to be placed under $MY_WORKSPACE, so
    set $MY_WORKSPACE as the current directory before creating the patch.

    Closes-Bug: 1915182
    Signed-off-by: Scott Little <email address hidden>
    (cherry picked from commit 71d5ae9df9268be2803e2a45277e65c7c84c1fdb)
    Change-Id: I8c34bc0c4697934cee2ca07334f817311c574872

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/root/+/792232

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/root/+/792232
Committed: https://opendev.org/starlingx/root/commit/7cb55d28111dbf7458ed3f01a5eda5c4dfdb124b
Submitter: "Zuul (22348)"
Branch: f/centos8

commit f457bd15b9ce0be512ec96abcb9b858b0bab2ea8
Author: Scott Little <email address hidden>
Date: Fri Apr 16 01:39:17 2021 -0400

    Improved branching tools

    create_branches_and_tags.sh:
    - Update the .gitreview files in branched git repos.
    - When updating a manifest, add the ability to update and
      use the default revision field.
    - Create two levels of manifest lockdown, soft and hard.
      Soft lockdown only sets sha revisions on unbranched projects
      that lack a revision, or set the revision to master.
      Hard lockdown applies to all unbranched projects.

    push_branches_tags.sh:
    - opendev no longer accepts 'git push' for the delivery of
      new branches with updates. Instead we must now
      use separate commands to deliver the tag, the branch,
      and any updates.

    Closes-Bug: 1924762
    Signed-off-by: Scott Little <email address hidden>
    Change-Id: I6d669ddc80cc9b3cb9e72d65a64589dbccf43ae3

commit 0babd33b6d851dd11492c26e92c8a6ac2c2557de
Author: Rafael Jardim <email address hidden>
Date: Wed May 12 11:25:54 2021 -0300

    Update stx-platformclients tag to stx.5.0-v1.4.3

    This commit updates the image with the updated clients.

    Test:
    Some normal commands
    Commands related with https dcmanager that wasn't working
    System application-upload that wasn't working when executed
    from remote cli

    Closes-Bug: 1928233
    Closes-Bug: 1928231
    Signed-off-by: Rafael Jardim <email address hidden>
    Change-Id: I8a0d12f699336a4412be5ff3c73cfb8d59038780

commit a163d7723e659e89c37ec933d1b0f9aa638a6a73
Author: Cole Walker <email address hidden>
Date: Wed May 5 09:39:17 2021 -0400

    Update image tag for notificationservice-base

    Update image tag to stx.5.0-v1.0.4 for notificationservice-base

    Closes-Bug: 1924201
    Closes-Bug: 1924197

    Signed-off-by: Cole Walker <email address hidden>
    Change-Id: Id863c4f154cc0b39e30ee8986fc07f9856a22826

commit 84c45f5e3a241237887af9db89d8c0aa1f8923e0
Author: Charles Short <email address hidden>
Date: Sun May 2 12:04:04 2021 -0400

    Fix wheels tarball generation

    In d7c5a54ab94bce6635b83d91a807d28f97836a81, django was dropped in favor
    of rfc3986. However the wheel was not added to the build-wheels
    generation which breaks the docker images. Also add the migrate wheel
    since it was mising as well. Add the required wheels in order to
    build the docker image properly.

    Test:
    - Build new centos-stable-wheels tarball
    - Build stx-keystone-api-proxy container

    Closes-Bug: 1926795

    Signed-off-by: Charles Short <email address hidden>
    Change-Id: Ib6f0abfdcc82ca14f92ebc5b45fe8df961e804ee

commit 062353b6de7d4b0e017203c3e6086891bd6b9213
Author: Cole Walker <email address hidden>
Date: Mon May 3 09:48:54 2021 -0400

    Update image tag for notificationclient-base...