Accept unsupported Function 'Patch Individual VNFInstance'

Bug #1915100 reported by YaoYudie
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tacker
Fix Released
Medium
kexuesheng

Bug Description

When testing the unsupported function 'Patch Individual VNFInstance',the API request is accepted(http code 200) and also a vnfLcmOpOccId is returned in header Location.
Although the request is accepted, the vnfinstance's information isn't changed but the status of vnf instance turned error.
Thing is that, we can't find any information about this error status unless we do some other information with the vnf instance or check in the database.
What's more, Since a vnfLcmOpOccid in the header location, the operation is supposed to be rollbacked. However, we can't rollback because there's no record about this id in database

operation log:
root@ubuntu:~# curl -i -X PATCH http://172.22.39.3:9890/vnflcm/v1/vnf_instances/2f5314e6-09b1-48a2-ac25-473cedaa4100 -H "Content-type: application/json"
-H "X-Auth-Token:$OS_AUTH_TOKEN" -d '{"vnfInstanceName": "vnf new name","vnfInstanceDescription": "new description"}'
HTTP/1.1 202 Accepted
Content-Type: application/json
Content-Length: 0
Location: http://localhost:9890//vnflcm/v1/vnf_lcm_op_occs/8009101c-6912-4dec-8d49-20e00a53a177
X-Openstack-Request-Id: req-6918ba57-afbb-410d-82c3-0f3b17a19227
Date: Thu, 28 Jan 2021 01:29:22 GMT

root@ubuntu:~# openstack vnflcm delete 2f5314e6-09b1-48a2-ac25-473cedaa4100
Failed to delete vnf instance with ID '2f5314e6-09b1-48a2-ac25-473cedaa4100': Vnf 2f5314e6-09b1-48a2-ac25-473cedaa4100 in status ERROR. Cannot delete while the vnf is in this state.
Failed to delete 1 of 1 vnf instances.

YaoYudie (yaoyudie)
Changed in tacker:
assignee: nobody → YaoYudie (yaoyudie)
Changed in tacker:
assignee: YaoYudie (yaoyudie) → nobody
Yasufumi Ogawa (yasufum)
Changed in tacker:
importance: Undecided → Medium
kexuesheng (kexuesheng)
Changed in tacker:
assignee: nobody → kexuesheng (kexuesheng)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tacker (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tacker/+/795021

Changed in tacker:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tacker (master)

Reviewed: https://review.opendev.org/c/openstack/tacker/+/795021
Committed: https://opendev.org/openstack/tacker/commit/a9cb38545262b9b793b81e7f409dc73fae072430
Submitter: "Zuul (22348)"
Branch: master

commit a9cb38545262b9b793b81e7f409dc73fae072430
Author: Yi Feng <email address hidden>
Date: Mon Jun 7 13:37:16 2021 +0900

    Fix Patch Individual VNF instance

    In the condition when the vnf instance hasn't been instantiated,
    an error occurs when Patching Individual VNF instance.

    1. Fix the exception caused by the NULL value of vnf's
    updated_at field.
    2. Fix the exception happened when one of its attributes is not
    existed in method to_dict in Class VnfInfoModifications.
    3. Fix the problem that vnfInstanceName and vnfInstanceDescription
    are not displayed in notification when vnfdId is included in the
    fields which need modified.
    4. In the API reference, modify the method of modifying an
    "Individual VNF instance" resource from POST to PATCH.

    Closes-Bug: #1915100
    Change-Id: Iddb5bb540b817d4fd24e2c7c12f885bd39f8662b

Changed in tacker:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tacker 6.0.0.0rc1

This issue was fixed in the openstack/tacker 6.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.