commit on bound branch yields KeyError

[John Dong]

I am using bzr 1.0-1 to commit to a bound packs branch over sftp into a repository. The latest packs format being used on both sides, the commit errors out with a KeyError:

[jdong@jdong:Documents/docs]$ bzr ci -m "Test commit" (02-12 19:10)
Committing to: sftp://linerva/~/docs/head/
added Courses/6.02
added Courses/6.02/lab1
added Courses/6.02/lab1/images
added Courses/6.02/lab1/images/prelab-1.png
added Courses/6.02/lab1/images/prelab-2.png
added Courses/6.02/lab1/images/prelab-3.png
added Courses/6.02/lab1/images/prelab-4.png
added Courses/6.02/lab1/images/prelab-5.png
added Courses/6.02/lab1/images/prelab-6.png
bzr: ERROR: exceptions.KeyError: 'sftp://linerva/%7E/docs/.bzr/repository/upload/zgtv97947b0hftiroguf.pack'

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 802, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 758, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 492, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/builtins.py", line 2334, in run
    author=author)
  File "/usr/lib/python2.5/site-packages/bzrlib/decorators.py", line 165, in write_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/workingtree_4.py", line 245, in commit
    result = WorkingTree3.commit(self, message, revprops, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/decorators.py", line 165, in write_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/mutabletree.py", line 187, in commit
    revprops=revprops, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/commit.py", line 403, in commit
    self._cleanup()
  File "/usr/lib/python2.5/site-packages/bzrlib/commit.py", line 587, in _cleanup
    raise e
KeyError: 'sftp://linerva/%7E/docs/.bzr/repository/upload/zgtv97947b0hftiroguf.pack'

bzr 1.0.0 on python 2.5.1.final.0 (linux2)
arguments: ['/usr/bin/bzr', 'ci', '-m', 'Test commit']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
  bazaar_webserve_dev /home/jdong/.bazaar/plugins/bazaar_webserve_dev [unknown]
  bzrtools /home/jdong/.bazaar/plugins/bzrtools [0.92.0]
  launchpad /usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad [unknown]
  multiparent /usr/lib/python2.5/site-packages/bzrlib/plugins/multiparent.pyc [unknown]
  pack_indices /home/jdong/.bazaar/plugins/pack_indices [unknown]
  svn /usr/lib/python2.5/site-packages/bzrlib/plugins/svn [0.4.7]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

[Robert Collins (lifeless)]

On Wed, 2008-02-13 at 00:15 +0000, John Dong wrote:
> Public bug reported:
>
> I am using bzr 1.0-1 to commit to a bound packs branch over sftp into a
> repository. The latest packs format being used on both sides, the commit
> errors out with a KeyError:
>
> [jdong@jdong:Documents/docs]$ bzr ci -m "Test commit" (02-12 19:10)
> Committing to: sftp://linerva/~/docs/head/
> added Courses/6.02
> added Courses/6.02/lab1
> added Courses/6.02/lab1/images
> added Courses/6.02/lab1/images/prelab-1.png
> added Courses/6.02/lab1/images/prelab-2.png
> added Courses/6.02/lab1/images/prelab-3.png
> added Courses/6.02/lab1/images/prelab-4.png
> added Courses/6.02/lab1/images/prelab-5.png
> added Courses/6.02/lab1/images/prelab-6.png
> bzr: ERROR: exceptions.KeyError: 'sftp://linerva/%7E/docs/.bzr/repository/upload/zgtv97947b0hftiroguf.pack'

Interesting
 importance high

can you please see if that file exits and get its md5sum, also look in
your repository/packs/ directory for a .pack with the same md5sum?

-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[John Dong (jdong)]

I should add that I retried this operation over bzr+ssh (where remote server ran bzr 1.1.0-rc) and it worked just fine.

[John A Meinel (jameinel)]

I wouldn't be surprise if it is the "~" => "%7E" that is screwing things up here.

[John Dong (jdong)]

Well the remote server is running AFS (MIT Athena) and it seems more likely that some sort of problem with SFTP in general would be a more likely culprit.

I can't reproduce the bug on any regular setups.

[John A Meinel (jameinel)]

Is this still reproducible?

[Jelmer Vernooij (jelmer)]

This has been incomplete for more than 800 days without a followup. I'm closing it for now, if you can still reproduce it please reopen.