Improve u-boot-menu in focal

[Dimitri John Ledkov]

[Impact]

 * Improve u-boot-menu UX in focal

[Test Case]

 * Boot riscv64 image built with new u-boot-menu

 * Observe that menu entry says "Ubuntu", instead of "Debian".

 * When booting, observe that riscv64 instance is booting with "earlycon" in the kernel commandline, without "quiet" such that one can see many kernel messages.

 * fstab comments parsing is fixed up

[Where problems could occur]

 * default cmdline is changed which might be unexpected. This can be changed in the config file that is documented in the manpage.

[Other Info]

 * only riscv64 image so far is using u-boot-menu by default in ubuntu.

[Steve Langasek (vorlon)]

Hello Dimitri, or anyone else affected,

Accepted u-boot-menu into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/u-boot-menu/4.0.1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Dimitri John Ledkov (xnox)]

booted focal riscv64 image in qemu VM.

updated to proposed, and installed the new u-boot-menu 4.0.1ubuntu0.1

upgrades to u-boot-menu did not regenerate /boot/extlinux/extlinux.conf.

as there is no kernel to update, i triggered u-boot-menu update by calling

$ sudo u-boot-update

Checking the /boot/extlinux/extlinux.conf it was updated and now has Ubuntu branding, non-quiet boot by default, and earlycon options set. root= argument is also parsed without issues. however my fstab currently doesn't have any comments either.

rebooting.

U-Boot menu
1: Ubuntu 20.04.1 LTS 5.8.0-14-generic
2: Ubuntu 20.04.1 LTS 5.8.0-14-generic (rescue target)
Enter choice: 1: Ubuntu 20.04.1 LTS 5.8.0-14-generic
Retrieving file: /boot/initrd.img-5.8.0-14-generic
157868702 bytes read in 230 ms (654.6 MiB/s)
Retrieving file: /boot/vmlinuz-5.8.0-14-generic
20092252 bytes read in 21 ms (912.4 MiB/s)
append: root=LABEL=cloudimg-rootfs ro earlycon
## Flattened Device Tree blob at ff73fa40
   Booting using the fdt blob at 0xff73fa40
   Using Device Tree in place at 00000000ff73fa40, end 00000000ff743d9d

Starting kernel ...

[ 0.000000] OF: fdt: Ignoring memory range 0x80000000 - 0x80200000
[ 0.000000] Linux version 5.8.0-14-generic (buildd@riscv64-qemu-lcy01-088) (g
cc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0, GNU ld (GNU Binutils for Ubuntu) 2.34)
#16~20.04.1-Ubuntu SMP Wed Jan 20 18:22:58 UTC 2021 (Ubuntu 5.8.0-14.16~20.04.1-
generic 5.8.18)
[ 0.000000] earlycon: ns16550a0 at MMIO 0x0000000010000000 (options '')
[ 0.000000] printk: bootconsole [ns16550a0] enabled
[ 0.000000] Initial ramdisk at: 0x(____ptrval____) (157872128 bytes)
[ 0.000000] Zone ranges:

Reading the above you can see that U-boot menu is now branded, and the boot is not quiet.

[Launchpad Janitor (janitor)]

This bug was fixed in the package u-boot-menu - 4.0.1ubuntu0.1

---------------
u-boot-menu (4.0.1ubuntu0.1) focal; urgency=medium

  * SRU UX improvements from 4.0.2ubuntu2 to focal LP: #1913468

  [ Dimitri John Ledkov ]
  * Make default U_BOOT_PARAMETERS to be "ro earlycon". If one is using
    embedded boards, most likely they want verbosity.

  * u-boot-update: use PRETTY_NAME from os-release as menu label.

  [ Vagrant Cascadian ]
  * fix comment handling in in /etc/fstab

 -- Dimitri John Ledkov <email address hidden> Wed, 27 Jan 2021 17:08:03 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for u-boot-menu has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Brian Murray (brian-murray)]

I'm setting this to Won't Fix for groovy given that its EoL is coming up shortly. Feel free to switch it back if you plan on fixing this there.