Don't display page description on page itself

[Kristina Hoeppner]

In Mahara 20.10 we removed the formatting options from the page description to turn it more into metadata than anything that should be displayed on the page itself.

We should then also remove it from the page and not display it there any more as the display cannot be changed by a portfolio owner.

To replicate:

1. Create a page.
2. Add a page description.
3. Add one block to the page.
4. Display the page.
Expected result: The page description is not displayed.
Actual result: The page description is displayed above the first row of blocks.

The page description will still display on the 'Pages and collections' overview page.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11538

[Gold (gold.catalyst)]

Testing:

1. Create a page.
2. Add text to the Page description.
3. Add one block to the page.
4. Display the page.
5. Assert the text you entered in the Page description is not present.
6. View the Pages and collections
7. Assert the Page you created is present and the Page description text is visible.

[Gold (gold.catalyst)]

I've removed the line that set the variable in that template. I'm seeing it being set in a few other locations but don't have context to determine if it should be removed in those also.

The file viewcontent.json.php sets it on line 27. I don't know where or how this file is used though.

It appears to be used in descriptionblock.tpl as well. However, I can't find where this template is being used at all.

It also appears in the export code. I don't know if it should remain in that though.

[Lisa Seeto (lisaseeto)]

An update via Kristina:
We do display the description in the 'My portfolios' and maybe even the 'Latest changes' blocks. So if they are on the dashboard in the full export, we would need to bring the description along, just not display it on the page. Also, if other Leap2A compatible software display a description, it would be good not to lose it

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11538
Committed: https://git.mahara.org/mahara/mahara/commit/4044adbd0a4815acb19484541e226c7d18e88778
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4044adbd0a4815acb19484541e226c7d18e88778
Author: Gold <email address hidden>
Date: Wed Feb 3 09:02:17 2021 +1300

Bug 1913386 Don't display page description on page itself

Removed the Page description from the view template.

Removed where that was being set in Smarty too.

Updated tests that checked for Description text and asserted that it
*should not* be seen.

Also updated some behat secenario background definitions for
readability.

Change-Id: I56221931dd648733b054b6fbbefcc4c9da4c0b8c