Angular Staff Catalog: Make search form sticky on detail page

[Terran McCanna]

In 3.6.1 Angular Staff Catalog:

On the item details page, if you click "Show Search Form" it will expand the search form, but there is no way to collapse it.

It would both be nice to be able to collapse it, and to also make that a sticky setting so that it either stayed open or closed depending on user preference.

[Elizabeth Thomsen (et-8)]

This is on our list as well, and we've talked a bit about preferences here, but having it be sticky is probably all we need. We also agree that if you expand it, you should be able to collapse it. (Is there ever a reason to have an element that can be expanded but not collapsed, or collapsed but not expanded?)

[Bill Erickson (berick)]

Here's a branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1913338-staffcat-sticky-search-display-v1

As implemented, there are certain pages where we collapse the form by default (record detail, holds) and on those pages the user now has sticky expand/collapse options. Pages where collapsing is not currently possible (e.g. main search page) does not display the options.

I chose this approach because I'm assuming one of the more common use cases is that the form be expanded on the main search page then optionally collapsed on the hold/detail pages. In other words, there are pages where you definitely want to see the search form and having to manually expand it every time would get old. Hope that makes sense.

[Elaine Hardy (ehardy)]

I have tested this on a PINES concerto test server and it works as requested.I have tested this code and consent to signing off on it with my name, Elaine Hardy and my email address, <email address hidden>.

[Chris Sharp (chrissharp123)]

Found a typo in the seed values script. Corrected here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1913338-staffcat-sticky-search-display-v1

[Gina Monti (gmonti90)]

I, Gina Monti, sign off on this bug fix. The Show Search Form collapsable frame remains sticky.

[Galen Charlton (gmc)]

Pushed all the way down to rel_3_6 along with a minor ARIA coding follow-up. Thanks, Bill, Elaine, Chris, and Gina!