Force action will clear subsequent blocks

[Lindsay Stratton]

I am not sure if this duplicates https://bugs.launchpad.net/evergreen/+bug/1735566, the specifics are a little different, but the fundamental principles seem similar.

I am using version 3.4.5.

Reported problem - a patron is blocked for excess fines, but a new checkout is processed without the "Exceptions occurred during checkout / PATRON_EXCEEDS_FINES" override.

On testing, I found that a normal (item status is Available) checkout attempt on a fine blocked patron triggered the override as expected. After checking in the 1st test checkout, I repeated the checkout. This time, the item had been put into transit to its home library.

I scanned the item in checkout to the same blocked patron. This triggered an "Item in Transit / Cancel Transit then Checkout" prompt. Clicking through that opened an "Item Not Available / Item Status: Canceled Transit" override. On clicking Force this Action, the item was checked out without further check for the patron blocked status.

[Terran McCanna (tmccanna)]

This may be intended behavior (at least while the patron account is still open, or during the same session). My thought is that if I have a patron who has 10 items to checkout and I decide to override their excess fines block, I would want to do that for all of those items rather than have to approve the override for each one.

[Lindsay Stratton (lstratton)]

Normally, yes - if I am intentionally overriding a fine block, I want the override for all the checkouts for that patron.

In my original report I did NOT want to override the fine block, but there was a different override - item in transit/cancel transit > item not available / canceled transit - to clear before the fines. That unrelated override also cleared the fine block.

This is, admittedly, a fringe case, but it would be ideal if there were some way differentiate the types of override - for example: issues with items (bad status), issues with patrons (blocked), etc.

[Andrea Neiman (aneiman)]

Since there's changes coming to checkout overrides in 3.8 with the new Override Actions work in bug 1908439, this piqued my curiosity to see if it still persisted in 3.8-beta.

(I don't recall that this specific case was tested for with Override Actions)

Following Lindsay's steps in a 3.8-beta test system, I get the same result:

- Retrieved a patron with max fines
- Attempted to checkout an item in transit
- Presented with the "item in transit" dialog (expected, since this is a non-overrideable state, i.e. something needs to be done - like checkin - in order to make this item available)
- Clicked "cancel transit then checkout"
- Presented with the "item not available: item status cancelled transit" dialog (expected, since in this test system "Cancelled Transit" is not considered an Available status).
- Clicked "force this action"
- Item checked out without a peep about patron_exceeds_fines (not expected)

Checkouts of non-transit items did flag the max fines override dialog as expected.

What I did not test is if this is specifically tied to transit or if it's a bug affecting any checkout attempt of an item in a non-available status.

[Terran McCanna (tmccanna)]

Ah! Please ignore my comment #1 then, I misunderstood the problem!