Removing all entries in the library manager still leaves music in the library (can't empty it!)

[Marc Poulhiès]

When removing all items from the library manager does not empty the library (I still have items in my collection).

Please also find attached a trivial patch that removes the following Traceback when 'Remove' is clicked when the list of directories is empty.

Traceback (most recent call last):
  File "/usr/lib/exaile/xl/gui/library.py", line 100, in on_remove
    index = self.list.rows.index(item)
ValueError: list.index(x): x not in list

[Marc Poulhiès (marc-poulhies)]

(this traceback can also be raised when nothing is selected in the list and 'remove' is clicked)

[reacocard (reacocard)]

needs info: is bug still present in trunk?

[Ben Beasley (ben-musicinmybrain)]

If I try this with the latest bzr version, I get no traceback in the console and the Scanning Collection... progress bar appears, but it never makes any progress and the collection is not emptied.

Actually, if I remove a location from the collection manager, its contents don't seem to disappear from my collection even if there is another location remaining in the collection manager, although the (very fast) rescan does complete successfully.

[reacocard (reacocard)]

should be fixed in trunk as of r1770.