Style updates

Bug #1912414 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
20.10
Fix Released
High
Gold
21.04
Fix Released
High
Evonne Cheung

Bug Description

- Make comment public /portfolio/feedback.html: sits in the middle and doesn't have the correct class. Remedies:
 - Add correct class so that it's left-aligned and a button
 - Remove the dash after 'This comment is private'.
- Comment with attachment: size is still displayed and download icon doesn't have tooltip that includes file name and size
- Objectionable content: When page seen in 'Shared by me' page, it's missing the 'Portfolio under review' markup: https://manual.mahara.org/en/20.10/portfolio/objectionable.html#remove-objectionable-material-as-portfolio-author (screenshot right above this section)
- Plans: The word 'Template' is way too small on the plans overview page. Remedy: Make it bigger, change to span and put it behind the title of the plan.
- Plans: View page and also Edit: Remove red background for overdue plan item as well as the red from its heading
- Plans: Edit on a page: The chevron on the task sits awkwardly. Remedy: Move buttons up so that the chevron is then right-aligned
- Mark a forum post as objectionable: The alert icon to the left of the profile icon of the post that you are reporting is missing. Remedy: Remove the alert classes as the post doesn't need to be marked up as alert because it's not yet been reported.
- Once forum post has been reported, change the red text for 'Reported details' to black.
- Legal: Expanded item has the chevron in the wrong direction.
- Legal: The 'Last update' date moved to the bottom from the top right hand corner. Remedy: Leave it on the left, but move it above the text.
- Elasticsearch result page, on kiaora search for learning, portfolio, biology: Journal entry is pushed to the left. Remedy: Row needs to be inherited
- People search: The calendar icon sits outside of the date box in Advanced -> Last login
- Skin: - heading within a text block uses the block heading font when it should not do that.
- Group's about page - under Group Portfolios heading, when a page/collection is a template, it has a button on the right to allow copying, tpl needs to be updated so it aligns to top of the list-group-item.
- Look into the btn-group-top responsiveness, too many overrides for specific pages, like comments remove button, it seems to require an extra pixel around md breakpoint, would like to clean this up.

Tags: front-end
Evonne Cheung (evonne)
description: updated
Evonne Cheung (evonne)
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11526

Revision history for this message
Evonne Cheung (evonne) wrote :

- Objectionable content issue seems to have something to do with $item.pending as all the classes are there already, it's not pulling thru, requires dev to look into

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/11536

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11536
Committed: https://git.mahara.org/mahara/mahara/commit/e105d8aa6909d59783aeceaafd4307350ad95437
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e105d8aa6909d59783aeceaafd4307350ad95437
Author: Gold <email address hidden>
Date: Fri Jan 29 11:30:31 2021 +1300

Bug 1895066

Draft peer assessment needs additional indicator besides colour

Added a 'draft' string to "view" and used that in the template.
Updated the 'draft' string in "blocktype.peerassessment/peerassessment"
to 'savedraft' to prevent confusion.
Added 'pubstatus' to the item if it is private and set this to Draft.
Added pubstatus to the template if set to private. Style for this
replicates the private status on Bug 1912414.

Change-Id: I9cb0b20f9e00536e3162c3f83583b4877a6913a9

description: updated
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11526
Committed: https://git.mahara.org/mahara/mahara/commit/6c312125d2df94d14e8c7dde2f05ba0a1098cc77
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6c312125d2df94d14e8c7dde2f05ba0a1098cc77
Author: Evonne <email address hidden>
Date: Tue Jan 26 14:37:16 2021 +1300

Bug 1912414 Style updates

- Make comment public /portfolio/feedback.html: sits in the middle and
doesn't have the correct class.
- Comment with attachment: size is still displayed and download icon
doesn't have tooltip that includes file name and size.
- Objectionable content: When page seen in 'Shared by me' page, it's
missing the 'Portfolio under review' markup.
- Plans: The word 'Template' is too small on the plans overview page.
- Plans: View page and also Edit: Remove red background for overdue plan
item as well as the red from its heading.
- Plans: Edit on a page: The chevron on the task sits awkwardly.
- Mark a forum post as objectionable: The alert icon to the left of the
profile icon of the post that you are reporting is missing.
- Once forum post has been reported, change the red text for 'Reported
details' to black.
- Legal: Expanded item has the chevron in the wrong direction.
- Legal: The 'Last update' date moved to the bottom from the top right
hand corner.
- Elasticsearch result page, journal entry is pushed to the left.
- Account settings in admin area: Calendar icon below last login sits
outside of box.
- Skin: - heading within a text block uses the block heading font when
it should not do that.
- Group's about page - under Group Portfolios heading, when a page/
collection is a template, it has a button on the right to allow
copying, tpl needs to be updated so it aligns to top of the
list-group-item.
- Look into the btn-group-top responsiveness, too many overrides for
specific pages, like comments remove button, it seems to require an
extra pixel around md breakpoint, would like to clean this up.

behatnotneeded

Change-Id: Icfffed9376e89339a8fad5a207d3b974b431e451

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11597

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11598

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11598
Committed: https://git.mahara.org/mahara/mahara/commit/810e5acc5956a67b92785f1cbf838cb45472881c
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit 810e5acc5956a67b92785f1cbf838cb45472881c
Author: Evonne Cheung <email address hidden>
Date: Tue Jan 26 14:37:16 2021 +1300

Bug 1912414 Style updates

- Make comment public /portfolio/feedback.html: sits in the middle and
doesn't have the correct class.
- Comment with attachment: size is still displayed and download icon
doesn't have tooltip that includes file name and size.
- Objectionable content: When page seen in 'Shared by me' page, it's
missing the 'Portfolio under review' markup.
- Plans: The word 'Template' is too small on the plans overview page.
- Plans: View page and also Edit: Remove red background for overdue plan
item as well as the red from its heading.
- Plans: Edit on a page: The chevron on the task sits awkwardly.
- Mark a forum post as objectionable: The alert icon to the left of the
profile icon of the post that you are reporting is missing.
- Once forum post has been reported, change the red text for 'Reported
details' to black.
- Legal: Expanded item has the chevron in the wrong direction.
- Legal: The 'Last update' date moved to the bottom from the top right
hand corner.
- Elasticsearch result page, journal entry is pushed to the left.
- Account settings in admin area: Calendar icon below last login sits
outside of box.
- Skin: - heading within a text block uses the block heading font when
it should not do that.
- Group's about page - under Group Portfolios heading, when a page/
collection is a template, it has a button on the right to allow
copying, tpl needs to be updated so it aligns to top of the
list-group-item.
- Look into the btn-group-top responsiveness, too many overrides for
specific pages, like comments remove button, it seems to require an
extra pixel around md breakpoint, would like to clean this up.

behatnotneeded

Change-Id: Icfffed9376e89339a8fad5a207d3b974b431e451
(cherry picked from commit 6c312125d2df94d14e8c7dde2f05ba0a1098cc77)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11597
Committed: https://git.mahara.org/mahara/mahara/commit/5502148244239c5352c73a5e2ab62aac7292088e
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit 5502148244239c5352c73a5e2ab62aac7292088e
Author: Gold <email address hidden>
Date: Fri Jan 29 11:30:31 2021 +1300

Bug 1895066 - add text indcator of draft state to peer assessment

Draft peer assessment needs additional indicator besides colour

Added a 'draft' string to "view" and used that in the template.
Updated the 'draft' string in "blocktype.peerassessment/peerassessment"
to 'savedraft' to prevent confusion.
Added 'pubstatus' to the item if it is private and set this to Draft.
Added pubstatus to the template if set to private. Style for this
replicates the private status on Bug 1912414.

Change-Id: I9cb0b20f9e00536e3162c3f83583b4877a6913a9
(cherry picked from commit e105d8aa6909d59783aeceaafd4307350ad95437)

no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.