Backdated checkin effective time ignores timezone

[[e-mail]]

This could be related to #1335939.

1. We noticed that at 4pm Pacific Time the backdated checkin effect time increases by 1 day. For example, for a chosen effect date of 2021-01-04, the effect date for checkin done at 3:59pm is 2021-01-04, but at 4:01pm is 2021-01-05. It looks that timezone of the chosen 01-04 is not taken into consideration when calculating the effective due time.

This could be related to #1335939.

2. We also noticed an hour difference in the effective checkin time in our test circs, which were done in different timezones, thus with different due time. Jeff found a comment related to this.

---According to a comment in
Open-ILS/web/js/ui/default/staff/circ/checkin/app.js, backdated checkins
currently get the time portion of the checkin timestamp from the due
date.

A proper fix would be to set the time portion of the checkin timestamp
correctly when backdating, rather than copying the time portion of the
due date. A related bug #1793817

Tina Ji
BC Libraries Coop