EDI Order Pusher needs tighter control over PO selection
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Confirmed
|
High
|
Unassigned |
Bug Description
EG 3.5
We've found that the new EDI order pusher (edi_order_
A provider is put into use for a long time. One that has never had an EDI account. And then, we add an EDI account. Once that is added, the EDI pusher will collect ALL of the PO's that don't have an associated ORDERS message but have state='on-order'. Which will be a bad thing.
Another scenario:
Once adopting the new order pusher software without checking the database, you might be surprised how many old PO's still have "on-order" and never received an ORDERS message. Those orders will then be pushed to the provider.
These issues can be mitigated if we applied a flag of some sort onto the PO when it's activated. One that would signify the method of delivery that this PO should be using. The related IRC chat:
http://
The proposed fix is:
1. Add a column to acq.purchase_order (delivery_method TEXT DEFAULT 'none'
2. Allowed text phrases should be limited to "edi", "manual", "none"
3. "none" would be the default on row insertion for non-activated orders.
4. Teach edi_order_pusher about the new column and filter the targeted PO's accordingly.
What about your suggestion in bug 1803734 of just including a sane order_date?