glance status upgrade check fails with TypeError

[Cyril Roelandt]

When the 'enabled_backends' option has not been set, it defaults to None and we get the following error:

$ touch test.conf
$ glance-status --config-file=./test.conf upgrade check
Error:
Traceback (most recent call last):
  File "/home/cyril/openstack/glance/v/lib/python3.9/site-packages/oslo_upgradecheck/upgradecheck.py", line 196, in run
    return conf.command.action_fn()
  File "/home/cyril/openstack/glance/v/lib/python3.9/site-packages/oslo_upgradecheck/upgradecheck.py", line 106, in check
    result = func(self)
  File "/home/cyril/openstack/glance/glance/cmd/status.py", line 36, in _check_sheepdog_store
    if 'sheepdog' in getattr(CONF, 'enabled_backends', {}):
TypeError: argument of type 'NoneType' is not iterable

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/glance 22.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/glance/+/849998

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/glance/+/849998
Committed: https://opendev.org/openstack/glance/commit/691206b4e8aeb822ec8be9f9e4c37c4b5d3245a3
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 691206b4e8aeb822ec8be9f9e4c37c4b5d3245a3
Author: Cyril Roelandt <email address hidden>
Date: Thu Jan 14 02:52:23 2021 +0100

    Fix upgrade checks for sheepdog

    When either CONF.enabled_backends or CONF.glance_store.stores is set to
    None (which may happen if they are not actually specified in the config
    file), a TypeError is raised. Fix this and add tests.

    Change-Id: I670f6db96998c8a2cec5d16fbca9f01857b866da
    Closes-Bug: #1911700
    (cherry picked from commit c7236a0897b87c0a0ee21655139e527d66ed7105)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/glance victoria-eom release.