transaction category autofill from payee is too invasive

[baham]

Hello there !

I don't know if this is a bug or wanted :

1) I create an operation, when I set the Payee what I think is the most used category for this Payee is affected to the category
2) I set the category on (no category)
3) I save the operation, the list shows it correctly wih no category
4) I reopen it : the category is reset to the Payee one

Linked issue : for a split operation (with no category by design) the same thing happens : on the operation edition window the Payee's category is affected to the operation (and greyed as we cannot change the category for a split operation).

Windows 10
Homebank 5.4.3

Thanks for your work !

[Maxime DOYEN (mdoyen)]

1) I create an operation, when I set the Payee what I think is the most used category for this Payee is affected to the category
=> no, it is because you have set a default category for that payee from he manage payee category

But it is linked to #844576, maybe the autofill should occurs only when you add and not when you edit, as, I suppose for that txn you don't want that default payee ?

[baham (jerem-xiii)]

Oh I didn't know that we could set a default category !
It is indeed set for most of my Payees, but I don't remember setting it...

"maybe the autofill should occurs only when you add and not when you edit"
I think the Category should only be set to the default value when :
1) the Payee is modified
2) the Category is empty
3) the operation value is not split (Category must stay empty in this case)

[Maxime DOYEN (mdoyen)]

what I fixed is your case: block the autofill when you edit a txn, because it was called and should not.
the payee autofill remains: it only occurs if category/paymode are unset
category is still fill for split, I know, but it is ignored (and sometime people revert back a split to normal and so are happy to get back the correct category, meanwhile I agree I should leave this empty for clarity