Search Term Highlighting - option to turn off by default

[Terran McCanna]

When search term highlighting is enabled, it defaults to "on" and the user must check to disable it.

Changing the config setting to disable it hides the option entirely.

We'd like to see a setting in-between the two, so we could have the option available but have it "off" by default.

It would also be nice to have that setting be able to be saved in the user's search preferences since some users like the feature and some dislike it.

[Jennifer Weston (jweston)]

+1 to storing the setting as a user's search preference

The Disable Highlighting checkbox was useful in earlier versions prior to Angular Staff Catalog. In addition to individual preference, being able to disable the highlighting temporarily is helpful for documentation purposes when screenshots are needed -- for this purpose, the highlighting distracts from the intent of the image.

[John Amundson (jamundson)]

Related - https://bugs.launchpad.net/evergreen/+bug/1783408

[Terran McCanna (tmccanna)]

See also for staff catalog - https://bugs.launchpad.net/evergreen/+bug/1970946

[Steven Mayo (stmayo)]

Fixing this as part of a larger branch focused on search highlighting. Changes are bundled with changes for https://bugs.launchpad.net/evergreen/+bug/1783408 and https://bugs.launchpad.net/evergreen/+bug/1970946 in the top two commits on this branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/smayo/lp1970946-Staff_Catalog_Disable_Highlight_Setting

Changed the setting in Open-ILS/src/templates-bootstrap/opac/parts/config.tt2 from search.no_highlight to search.default_highlight. When search.default_highlight is 0, highlighting for OPAC users who have not signed in will be off - until they click one of the buttons in their search results. When search.default_highlight is 1, users that aren't logged in will have highlighting on until they click the buttons.
No state for this setting hides the option to toggle highlighting anymore.
The default state of this setting is on.

There is ALSO a new user setting that users may save in My Account -> Preferences -> Search and History. This will override the consortium-wide default in config.tt2 IF it has been set AND the user is logged into their account.

Steps to test (for this ticket):
[1] Go to OPAC -> Basic Search
[2] Ensure you are logged out
[3] Search for any bib with results
[4] Ensure the results are highlighted and the checkbox 'Enable Highlighting' is checked
[5] Go to the bib record and ensure that's highlighted too
[6] Turn highlighting off and on a few times using the button on the bib record
[7] Return to results and turn highlighting off and on using the checkbox
[8] Contact whoever is in charge of your test server (it might be you!)
[9] Ask them to open Open-ILS/src/templates-bootstrap/opac/parts/config.tt2
[10] Ask them to change search.default_highlight to 0
[11] Ask them to apply the changes to your test server
[12] Tell them you appreciate them
[13] Clear your cache
[14] Return to OPAC -> Basic Search while still logged out
[15] Search for any bib with results
[16] Ensure the results are NOT highlighted and the checkbox is unchecked
[17] Toggle the checkbox a few times to make sure it works
[18] Go to any bib results and ensure the highlighting is the same
[19] Toggle the Enable/Disable Highlighting button a few times to make sure it works