Typing in input boxes from tools and Enter does not finalizes object like LIne (regression)

Bug #1909567 reported by grofaty
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Pinta
Fix Released
Undecided
Unassigned

Bug Description

I have downloaded Pinta 1.8 development for Ubuntu 20.04 from
https://github.com/PintaProject/Pinta/actions/runs/450000006

1. Select Line/Curve from Tools.
2. Draw a line on canvas.
3. At Arrow click on 2 and then click on + at Size to increase size.
4. On canvas there is still line without being finalized. In Pinta 1.7 you could press Enter to finalize objects, but in Pinta 1.8 if some input box is selected then finalize can't be executed by pressing Enter key.

Tags: gtk3
Revision history for this message
Cameron White (cameronwhite91) wrote :

Confirmed - this is probably related to the change that switched from combo boxes to spin buttons for these toolbar widgets.

Changed in pinta:
milestone: none → 1.8
status: New → Triaged
Revision history for this message
Cameron White (cameronwhite91) wrote :

Testing this more, the same issue did appear in v1.7 if you directly typed in the text field to change the size - the text field probably intercepts the Enter key before the canvas gets it. It's more noticeable now in 1.8 since pressing the +/- buttons puts your cursor in the text field, so now you always hit this issue.

A couple ideas would be:
- Pressing enter in one of these fields could "finish" editing the value, and return focus to the canvas
- Clicking on the canvas could remove focus from the text field
- Somehow change the key processing order so that the canvas can intercept it first. This would need careful testing to ensure there aren't any new issues introduced.

Revision history for this message
grofaty (grofaty) wrote :

Maybe not as a final solution, but what about pressing <Esc> to get out of any kind of input boxes.

For example also a problem (I think I reported this one too):
1. Text object and click on canvas.
2. Type in some text.
3. Press <Esc>
4. I expect this to finalize the text input box.
5. Ctrl+A to select whole canvas, Ctrl+C to copy. Ctrl+Alt+V to paste image in new image. And the last text from step 2 is not present in new image. This is the problem in Pinta 1.7 and 1.8.

What would be great is when pressing <Esc> to get out of ANY input box (Text box on canvas and text boxes from toolbar).

Revision history for this message
Cameron White (cameronwhite91) wrote :

https://github.com/PintaProject/Pinta/commit/63942941b263dcd64b4f5371d4ae0e07c1137e34

The behaviour should now be more like it was in Pinta 1.7

Changed in pinta:
status: Triaged → Fix Committed
Changed in pinta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.