ZEO/Blob support: superfluous file existence test
Bug #190884 reported by
Christian Theune
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
ZODB | Status tracked in 3.9 | |||||
3.8 |
Fix Released
|
High
|
Christian Theune | |||
3.9 |
Fix Released
|
High
|
Christian Theune |
Bug Description
In ZEO.ClientStorage around line 1035 there is a test that after `server.sendBlob` the file exists, otherwise an exception is thrown.
We consider this to be superfluous, because:
- if the file could not be sent then `sendBlob` should have raised an exception
- the test whether the expected file exists therefore only covers the possibility
that someone outside the system removed the file. However, this test and the `return`
are not atomic and therefore the test doesn't really help.
Our point is somewhat supported by the fact that no test exists for the code path where
the exception would be raised. This in turn currently hides a NameError.
To post a comment you must log in.
Committed in r83744.