Angular Staff Catalog: Copy table sort order

[Terran McCanna]

In 3.6.1:

The holdings on the item table don't appear to be in any obvious order.

Ideally, they'd default to being in order by location, with the columns being sortable.

[Elaine Hardy (ehardy)]

Also being able to view holdings from a single library or system as in holdings view would also be helpful

[Terran McCanna (tmccanna)]

Noting that this is still a big problem for our consortium since most items have so many holdings.

[Terran McCanna (tmccanna)]

After looking at this with Bill - the sorting is being done by the branch name, but the display is the branch code which is why it doesn't appear to be in order. Changing the sort to sort by branch code would resolve the issue.

[Bill Erickson (berick)]

Here's a branch to address the org unit shortname sorting:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1908623-cat-items-org-shortname-sort

[Susan Morrison (smorrison425)]

Confirmed the org units in the item table are grouped and sorting based on order in org unit tree.

I have tested this code and consent to signing off on it with my name, Susan Morrison, and my email address, <email address hidden>.

[Terran McCanna (tmccanna)]

Removing signoff because although at first glance in Concerto data it appears to work, it's still actually displaying in the same order as a branch without the patch.

In this screenshot, I would either expect BM1 to appear a) between BR3 and BR4 because it is a sublibrary of BR3, or b) first because then it would be alphabetical by shortname.

[Steven Mayo (stmayo)]

We've figured out why sub-libraries were sorted to the bottom.

evergreen.rank_ou is higher priority than the custom sort field (shortname here) for sorting on this page. It sorts whether or not a library is the user's preferred library, which we want, but if none are preferred it also ranks libraries based on org tree distance. (number of steps up and down)
Because sublibraries are further than every other library in org unit steps, they are displayed last.

We're hesitant to change evergreen.rank_ou because we're not sure what else it would change, but our next steps for fixing this are probably to add a variation of evergreen.rank_ou that ignores distance if you pass it a boolean.

[Jane Sandberg (sandbergja)]

Removing targets, since there is not an active pullrequest.