Prevent multiple server processes from being created by oils_ct.sh

Bug #1908455 reported by Clayton Liddell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.10
Fix Released
Undecided
Unassigned
3.9
Fix Released
Undecided
Unassigned

Bug Description

Evergreen Version: master
OS Version: Ubuntu 18.04

In the process of following the instructions on installing the SIP Server for Evergreen ILS in the documentation (over at https://docs.evergreen-ils.org/eg/docs/latest/admin/sip_server.html#_installing_the_sip_server), I realized that I needed to modify my oils_sip.xml settings file and restart the server.

After making the necessary changes to my settings file, rather than restarting the server using the oils_ctl "restart_sip" action, I instead (accidentaly) used the "start_sip" action on the already running server instance. This resulted in a message being displayed: "OILS SIP Server already started : PID". However, an attempt was made by the oils_ctl.sh script to start a new SIP server instance inspite of a process running an existing server instance being detected.

The new server instance failed to start on account of the existing one, however the PID associated with the existing instance was swapped out with a new one as a consequence. I noticed the changes I had made to my oils_sip.xml settings file hadn't taking affect and attempts to stop the existing server instance via `oils_ctl -a stop_sip` weren't working.

I was able to track down the PID of the existing server instance and kill it, and further research led me to the discovery of this bug.

In order to prevent this from occurring I'm suggesting we simply respect the result of the check made for running server processes before attempting to start a new server instance.

Please observe the attached patch.

Tags: performance
Revision history for this message
Clayton Liddell (cbwliddell) wrote :
tags: added: performance
Revision history for this message
Jason Boyer (jboyer) wrote :

Problem and fix confirmed; I've pushed the fix to master, rel_3_9 and rel_3_10. Thanks Clayton!

Changed in evergreen:
status: New → Fix Committed
importance: Undecided → Medium
no longer affects: evergreen/3.11
Changed in evergreen:
milestone: none → 3.next
Changed in evergreen:
milestone: 3.next → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.