setting manila quota raises db error

[Paul Ali]

Setting any manila quota with a value greater than 2147483647 raises oslo_db.exception.DBDataError: (pymysql.err.DataError) which is communicated to the user as ERROR: The server has either erred or is incapable of performing the requested operation. (HTTP 500).

This is understandable given the mariadb integer limit of 2147483647.However, a more descriptive error should be communicated to the user as when a share quota that is less than -1 is being set.A more descriptive error message is reported to the user :
ERROR: Quota limit must be -1 or greater. (HTTP 400)

Steps to reproduce:

manila quota-update %share_id% --snapshots 10000000000

Actual Result:
ERROR: The server has either erred or is incapable of performing the requested operation. (HTTP 500) (Request-ID: req-1d03200b-623e-4ef8-a7d6-cfcdef01b98f)

Logs for manila API service
http://paste.openstack.org/show/801076/

[Tom Barron (tpb)]

Thanks for finding this bug, Paul. I confirmed it. Are you planning on submitting a fix yourself?

[Paul Ali (paulali)]

You are welcome Tom.I have assigned it to myself.I will work on it and submit a fix.

[Goutham Pacha Ravi (gouthamr)]

Fix proposed to branch: master
    https://review.opendev.org/782856

[Vida Haririan (vhariria)]

Additional comments https://meetings.opendev.org/meetings/manila/2021/manila.2021-06-24-15.00.log.html

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/782856
Committed: https://opendev.org/openstack/manila/commit/daf7b3aacf1481c967db4706e7cfa7be09976c52
Submitter: "Zuul (22348)"
Branch: master

commit daf7b3aacf1481c967db4706e7cfa7be09976c52
Author: paulali <email address hidden>
Date: Wed Mar 24 20:39:05 2021 +0000

    Adds a clear error message to operator-set limits

    When an operator sets a limit that is greater than 2147483647, an
    explicit error message "Quota limit should not exceed 2147483647"
    is communicated. This is better than the initial error message
    which was "ERROR: The server has either erred or is
    incapable of performing the requested operation. (HTTP 500)."

    Closes-Bug: #1908352
    Change-Id: I0d301c5f527c3e16e14021b679c85bd51833a1d6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/manila/+/798882

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/798882
Committed: https://opendev.org/openstack/manila/commit/2a6325951967c7dda52cb9c8beccd78e1cfb0605
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 2a6325951967c7dda52cb9c8beccd78e1cfb0605
Author: paulali <email address hidden>
Date: Wed Mar 24 20:39:05 2021 +0000

    Adds a clear error message to operator-set limits

    When an operator sets a limit that is greater than 2147483647, an
    explicit error message "Quota limit should not exceed 2147483647"
    is communicated. This is better than the initial error message
    which was "ERROR: The server has either erred or is
    incapable of performing the requested operation. (HTTP 500)."

    Closes-Bug: #1908352
    Change-Id: I0d301c5f527c3e16e14021b679c85bd51833a1d6
    (cherry picked from commit daf7b3aacf1481c967db4706e7cfa7be09976c52)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 13.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 12.1.0 release.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/820952

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/820952
Committed: https://opendev.org/openstack/manila/commit/021e7ab02f30ae45c1ad20c5493c973d709fcd3e
Submitter: "Zuul (22348)"
Branch: master

commit 021e7ab02f30ae45c1ad20c5493c973d709fcd3e
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Dec 7 14:14:32 2021 -0800

    Move db release note to correct folder

    This change must be backported to stable/wallaby
    as well.

    Change-Id: I6d4f2cc263fc7dd099ce27e674709baf3916ea9b
    Related-Bug: #1908352
    Signed-off-by: Goutham Pacha Ravi <email address hidden>