Display course name when editing reserve item

[Beth Willis]

When editing an item on reserve only the course number and relationship display. It would be helpful if the course name also displayed here as this would help staff in differentiating among courses.

eg 3-6-1

[Jane Sandberg (sandbergja)]

Here is a branch for that: user/sandbergja/lp1907977_course_name_in_course_materials_editor

Here's a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1907977_course_name_in_course_materials_editor

And the testing notes from the commit message:

1) Go to Administration > Local > Course List
2) Make sure you have a variety of courses added.
3) Double click on a course that already has materials
attached to it.
4) Go to the materials tab.
5) Select a material and choose Edit
6) Note that the Course combobox shows both the course
number (HST243) and course name (History of Indonesia).
7) Note that you can blank out that field and type to
complete to get other courses in the same format.

[Beth Willis (willis-a)]

EG 3-6-1

I have tested this on our server and it works great. There is one tiny issue in that a closing parenthesis displays at the end of the course name. (please see attached screenshot.)

[Jane Sandberg (sandbergja)]

Good catch, Beth. That was just some sloppiness on my part. :-)

I force-pushed an updated commit that does not include that extra parenthesis.

[Beth Willis (willis-a)]

I have tested this code and consent to signing off on it with my name, Beth Willis, and my email address, <email address hidden>.

[Galen Charlton (gmc)]

Pushed to master and rel_3_6. Thanks, Jane and Beth!

There is one quirk that I want to call out: the selector for courses defaults to the course name. However, the combobox displays "COURSENUM: Course name", but if somebody knows the course number and starts typing it in, the combobox won't necessary bring up the expected results.

I think that either the selector should be changed to the course number or that the display format should become something like "Course name (COURSENUM)".