Can't tell if copies in distro upload queues contain binaries or not
Bug #1907429 reported by
Iain Lane
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Jürgen Gmach | ||
| ubuntu-archive-tools |
In Progress
|
Low
|
Colin Watson | ||
Bug Description
Querying for the contains_build property on a package_upload (queue entry) which is a copy always returns False.
This makes it impossible for queue reviewers to tell whether copies in the queue will result in binaries from the source being copied too, or if new builds will be scheduled. It is important to be able to know this if we want to be able to review copies, because we want to be able to ensure that distro builds are always done in a correct environment.
If it's convenient when fixing this, it would also be nice if the web UI also rendered the property's value too, e.g. by showing "(contains binaries)" when expanding copies, or rendering links to the artifacts like is done for non-copy queue entries.
Related branches
~cjwatson/ubuntu-archive-tools:queue-copy-contains-build
- Andy Whitcroft: Approve
-
Diff: 68 lines (+15/-9)1 file modifiedqueue (+15/-9)
~jugmac00/launchpad:expose-whether-copies-in-upload-queues-contain-binaries
- Colin Watson (community): Approve
-
Diff: 84 lines (+34/-5)2 files modifiedlib/lp/soyuz/model/queue.py (+18/-1)
lib/lp/soyuz/tests/test_packageupload.py (+16/-4)
Revision history for this message
| Łukasz Zemczak (sil2100) wrote | #1 |
| Changed in launchpad: | |
| assignee: | nobody → Jürgen Gmach (jugmac00) |
| status: | New → In Progress |
Revision history for this message
| Colin Watson (cjwatson) wrote | #2 |
| Changed in ubuntu-archive-tools: | |
| status: | New → In Progress |
| importance: | Undecided → Low |
| assignee: | nobody → Colin Watson (cjwatson) |
| Changed in launchpad: | |
| importance: | Undecided → Low |
| status: | In Progress → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Oh my, I always thought that I could work-around this by doing `queue fetch-urls` to determine that, to see if there are .debs present or not - but as Iain said, this seems to not work as syncs from PPAs *always* include the .deb links in the sync info regardless whether it's a source sync or not. This is really critical in that case.