[Queens] containers-tmpwatch cron job removes /var/log/containers/swift

[Takashi Kajinami]

Description
===========
The containers-tmpwatch cron job executes tmpwatch command to purge some old files under /var/log/containers.
However this currently includes symlink in files it processes, and purge /var/log/containers/swift symlink[1] a while after initial deployment.

[1] https://github.com/openstack/tripleo-heat-templates/blob/407991def9fa04cd6650e24deb1cdd267d6860ac/docker/services/swift-proxy.yaml#L251-L255

Steps to reproduce
==================
1. Deploy overcloud with LogrotatePurgeAfterDays:1
2. Wait for one day

Expected result
===============
/var/log/containers/swift is NOT deleted

Actual result
=============
/var/log/containers/swift is deleted

Environment
===========
The issue was initially observed in Queens.
Since Rocky a directory, instead of a symlink, is used for /var/log/containers so Rocky and later released are not affected.

https://review.opendev.org/c/765068

Logs & Configs
==============
N/A

[Takashi Kajinami (kajinamit)]

The fix has been submitted to master https://review.opendev.org/c/openstack/tripleo-heat-templates/+/765068

[Takashi Kajinami (kajinamit)]

I noticed that we do not expect the same issue since Rocky because we no longer use symlink but actual directory for /var/log/containers/swift[1]

[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/574221

So the problem is reproduced only in Queens deployment.

[Takashi Kajinami (kajinamit)]

This was fixed in queens by https://review.opendev.org/c/openstack/tripleo-heat-templates/+/765151 and we no longer have that symbolic link since rocky. So I think we are good to close this now.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Takashi Kajinami <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/765068

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates queens-eol release.