Bootstrap Opac - Phone number and email notifications not saved when placing hold

Bug #1903424 reported by Garry Collum
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned

Bug Description

In the Bootstrap opac the email and phone number notification (phone number) options that are input/selected when placing a hold are not saved to the database. SMS phone number and SMS carrier input is saved.

Revision history for this message
Garry Collum (gcollum) wrote :
tags: added: pullrequest
Michele Morgan (mmorgan)
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
Revision history for this message
Michele Morgan (mmorgan) wrote :

This works for me. Tested placing holds in the bootstrap opac with various notifications set. All were stored as expected in the hold. Also tested that, for phone notification, the notifications phone user preference was used if it existed, otherwise day phone was used, consistent with current behavior.

My signoff branch is here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1903424_signoff

tags: added: signedoff
Changed in evergreen:
assignee: Michele Morgan (mmorgan) → nobody
status: New → Confirmed
milestone: none → 3.6.1
Changed in evergreen:
importance: Undecided → High
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Great fix! Thanks, Garry and Michele. Pushed to master and rel_3_6.

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.