FreeBSD fix fs related bugs

Bug #1901958 reported by Andrey Fesenko
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cloud-init
Fix Released
Undecided
Unassigned

Bug Description

1) FreeBSD not support vfat use msdosfs
Original report https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250496
"Feel free to submit upstream if you have signed the CLA. I do not want to sign it."

2) if fs have trim: (-t) or MAC multilabel: (-l) flag, resize FS fail.
https://www.freebsd.org/cgi/man.cgi?query=tunefs&sektion=8

 2020-10-28 17:15:07,015 - handlers.py[DEBUG]: finish: init-network/config-resizefs: FAIL: running config-resizefs with frequency always
 ...
  File "/usr/local/lib/python3.7/site-packages/cloudinit/config/cc_resizefs.py", line 114, in _can_skip_resize_ufs
    optlist, _args = getopt.getopt(newfs_cmd[1:], opt_value)
  File "/usr/local/lib/python3.7/getopt.py", line 95, in getopt
    opts, args = do_shorts(opts, args[0][1:], shortopts, args[1:])
  File "/usr/local/lib/python3.7/getopt.py", line 195, in do_shorts
    if short_has_arg(opt, shortopts):
  File "/usr/local/lib/python3.7/getopt.py", line 211, in short_has_arg
    raise GetoptError(_('option -%s not recognized') % opt, opt)
 getopt.GetoptError: option -t not recognized

Revision history for this message
Andrey Fesenko (f0andrey) wrote :
Revision history for this message
Mina Galić (minagalic) wrote :

I'm not sure this portion of your patch makes sense, because the criteria is coming from outside the function
```
- elif criteria == "TYPE=vfat":
+ elif criteria == "TYPE=msdosfs":
```

so vfat is the clue, and then we go looking for msdos or msdosfs

Revision history for this message
Andrey Fesenko (f0andrey) wrote :

Most likely you are right, do I need to change the patch or will the committer do it?

Revision history for this message
Mina Galić (minagalic) wrote :
Changed in cloud-init:
status: New → In Progress
Revision history for this message
Chad Smith (chad.smith) wrote : Fixed in cloud-init version 20.4.

This bug is believed to be fixed in cloud-init in version 20.4. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

Changed in cloud-init:
status: In Progress → Fix Released
Revision history for this message
James Falcon (falcojr) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.