Carousel bucket id should be linked to bucket from grid

[Terran McCanna]

Wish list bug created from previous omnibus bug: https://bugs.launchpad.net/evergreen/+bug/1851879

In the carousels grid, it would be nice if the bucket ID value in the grid were linked directly to the bucket to save a few clicks.

[Terran McCanna (tmccanna)]

My solution for review is here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1901893_carousel_bucket_id_link

(Note: I don't really understand the purpose of the "System-generated bucket..." language in that column, but I left it as-is.)

[Mike Risher (mrisher)]

I tested this out and don't see a link to the bucket. These were the testing steps I went through:
- Apply the patch. Clear my cache and hard reload.
- visited Local Admin > Carousels
- Created a carousel for testing
- Filtered the grid so that I could see my newly created carousel.
- Checked to see if the ID number is hyperlinked and brings up a bucket. In my tests I see no hyperlink to click on.

If I missed any steps let me know. I'll hold off on marking it "needs repatch" til I'm confident I tested correctly.

Unrelated - when I double click a row, the carousel comes up for editing. But when I right click the row and select "Edit Selected" I get a JS error. "ERROR TypeError: this.showEditDialog is not a function"
I can create a new bug for this unrelated issue.

[Mike Risher (mrisher)]

New bug created for the problem mentioned above. Bug #1915321

[Terran McCanna (tmccanna)]

Hi Mike - this adds the link to the Bucket column (not the ID column). You can see it by making the Bucket column visible on https://terran-master.gapines.org now (during Feedback Fest this week).

Right-clicking to edit is working fine on my test machine too, so you might have something else going on with yours?

[Terran McCanna (tmccanna)]

(It's also loaded onto https://tiffany-master.gapines.org during Feedback Fest right now)

[Mike Risher (mrisher)]

Thanks for the explanation. The description of the bug mentions "if the bucket ID value in the grid were linked directly", so I thought I needed to look at the ID column.

Looking at the bucket column - I definitely do see it on the terran-master.gapines.org server. But when I apply the patch to my own local server I am not seeing the change. There's no <a href> tags around the relevant text. I must still be missing something in testing or applying in the patch.

[Garry Collum (gcollum)]

Mike, check to see if you have another bucket column that is not displayed. After applying the patch, I have 2 Bucket columns. One with a hyperlink, and one without.

[Terran McCanna (tmccanna)]

Thanks, Garry, I see what you mean now.

[Mike Risher (mrisher)]

Confirming what Garry is saying. There are two bucket fields, both with the same text, but only one is linked.

[Michele Morgan (mmorgan)]

Marking this Confirmed, also upping the importance. Users need to have better access to the buckets containing their carousel records. A user should not be required to open the Carousel editor to get to the record bucket, especially since it takes a long time for the modal to load for large systems.

[Michele Morgan (mmorgan)]

With a small tweak to Terran's patch, this is working for me now. I also took the liberty of making the bucket column visible by default. Branch is here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1901893_bucket_column_tweak

While testing this, I also noticed that grid settings for the Carousels admin pages are not saved. Opened bug 1920253 for that.

[Garry Collum (gcollum)]

Works great! A signed-off branch is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1901893_bucket_column_tweak-signoff

[Galen Charlton (gmc)]

Pushed down to rel_3_6. Thanks, Terran, Michele, and Garry!

Note that I added a follow-up to add a cellTextGenerator for the bucket column; that needs to be done whenever a cellTemplate is used so that CSV export from the grid has something to emit for that column.