Nesting Issues on the Bootstrap OPAC Record Detail Page
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
3.6 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Evergreen 3.6+
There are issues with tag nesting in the Bootstrap OPAC. Some cause more issues than others, but the W3C HTML validator can help track them down.
Multiple 856 links: it appears that the END tag for the FOR that cycles through the available links is in the wrong place. Multiple links in a single record gives you HTML that looks like this:
<ul>
<li class="rdetail_uri" property="offers" vocab="http://
<a href="LINK1" class="uri_link" property="url">
LINK1
<li class="rdetail_uri" property="offers" vocab="http://
<a href="LINK2" class="uri_link" property="url">
LINK2
<li class="rdetail_uri" property="offers" vocab="http://
<a href="LINK3" class="uri_link" property="url">
LINK3</a>
<link property=
</li>
</ul>
Note that only the last 856 has the </a><link></li> section.
There are other pages with similar issues. This kind of thing can potentially cause issues with CSS application. I'll try to put a branch together to address as many as I can find.
Changed in evergreen: | |
importance: | Undecided → Medium |
Changed in evergreen: | |
status: | New → Confirmed |
Changed in evergreen: | |
milestone: | none → 3.6.2 |
Changed in evergreen: | |
milestone: | 3.6.2 → 3.6.3 |
tags: | added: pullrequest |
Changed in evergreen: | |
milestone: | 3.6.3 → 3.6.4 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
I've got a few things taken care of here: https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ jboyer/ lp1901710_ html_nest_ tags / working/ user/jboyer/ lp1901710_ html_nest_ tags
but the advanced search page needs some real help.
A couple ids were changed to classes because they're now used in multiple places also.