Skip user/workstation setting updates when the value is unchanged

Bug #1901247 reported by Jeff Davis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
New
Undecided
Unassigned

Bug Description

EG 3.5+

When applying a user or workstation setting update, the client should check whether the setting value has actually changed. If not, skip the server-side update, since it's superfluous.

For example, circ.checkin.strict_barcode and circ.checkin.do_inventory_update are set on each checkin, since the values can change between checkins. But most commonly you'll have dozens or hundreds of checkins in a row where those settings don't change. We should check whether the value has changed before doing dozens or hundreds of unnecessary calls to open-ils.actor.settings.apply.user_or_ws.

Changed in evergreen:
assignee: nobody → Jeff Davis (jdavis-sitka)
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Attempted a fix in working branch user/jeffdavis/lp1901247-skip-user-ws-setting-updates but was unsuccessful. More work required. Unassigning myself in case someone else wants to take a shot.

Changed in evergreen:
assignee: Jeff Davis (jdavis-sitka) → nobody
Revision history for this message
Bill Erickson (berick) wrote :

Jeff, one suggestion is to use: "if (key in cache) { ... }" instead of "if (cache[key])" since many of the cached values may be null, false, or zero.

Andrea Neiman (aneiman)
tags: added: webstaffclient workstation
tags: added: orgunitsettings somirjoiurehtjgoire
tags: removed: somirjoiurehtjgoire
tags: removed: webstaffclient
tags: added: performance
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.