Angular Circulation Menu does not recognize "Number of Retrievable Recent Patrons" Library Setting

[Christine Morgan]

Observed in 3.4.3 and 3.5.1

The Circulation Menu options for "Retrieve Last Patron" and "Retrieve Recent Patrons" display in the Angular Circulation Menu no matter what value is set in the "Number of Retrievable Recent Patrons" Library Setting. Therefore, if the value in the setting is "0" or "1" the Angular Circulation menu will always display both the "Retrieve last patron" and "Retrieve recent patrons" options. The AngularJS Circulation menu will display "Retrieve last patron" if the library setting is "1" and neither menu option when the library setting is "0"

To test:
- Go to Administration menu --> Local Administration
- Select Library Settings Editor
- Scroll down the settings list to "Circulation - Number of Retrievable Recent Patrons"
- Click the Edit link and enter the value of "0" (neither option displays) or "1" (Retrieve last patron option displays).
- Click Save
- Log out of the client and then log back in.
- From the splash page, click on the Circulation menu and note the display of the Retrieve Last and Retrieve Recent Patron options.
- Navigate to an Angular page, like Local Administration and click on the Circulation menu. Note that both the Retrieve Last and Retrieve Recent Patron options display.

[Terran McCanna (tmccanna)]

Still an issue in 3.10.

[Dan Briem (dbriem)]

Branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp1901072_menus_recongize_max_recent_patrons_setting

[Susan Morrison (smorrison425)]

I have tested this code and consent to signing off on it with my name, Susan Morrison, and my email address, <email address hidden>.

[Jane Sandberg (sandbergja)]

This patch is working great! Pushed to rel_3_10 and above. Thanks, Dan and Susan!