Print Template for Checkout missing fields

Bug #1901028 reported by Terran McCanna
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
3.6
Fix Released
Low
Unassigned

Bug Description

In 3.4.2:

The inline documentation on the print template for Checkout indicates that these fields should be available, but are incorrect:

  * checkout.copy.call_number.label (not available)
  * checkout.copy.call_number.owning_lib.name (not available)
  * checkout.copy.call_number.owning_lib.shortname (not available)

(Note that they ARE available on the Items Out print template)

summary: - Print Template for Checkout won't print library name
+ Print Template for Checkout missing fields
description: updated
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

After looking at the underlying code, I found that the fields are actually available, but the hints that appear in the interface for the template were incorrect for these three as well as for the circ modifier. This should work:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1901028_checkout_print_template_fields

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.6.1
importance: Undecided → Low
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Revision history for this message
Kyle Huckins (khuckins) wrote :

In testing, this works, but the preview sample data for the print template needs to be adjusted in the circulations object as well. It looks like the call_number data should be moved from seed_copy to the circulation itself, but I'm not sure if it's used elsewhere for seed_copy, so whether it should be copied or just removed is a good question

tags: added: needsrepatch
removed: pullrequest
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Changed in evergreen:
milestone: 3.6.3 → none
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks Kyle - I've added a second commit to the seed data so that it displays properly in the print preview now as well as printing properly:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/working/lp1901028_checkout_print_template_fields

tags: added: pullrequest
removed: needsrepatch
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Revision history for this message
Jason Boyer (jboyer) wrote :
Changed in evergreen:
status: New → Confirmed
tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed down to rel_3_6. Thanks, Terran and Jason!

Changed in evergreen:
milestone: none → 3.7.2
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.