cifs without security service error not helpful

[Maurice Escher]

Description
===========
I'm running in DHSS=True mode with the NetApp driver.

To create a share with protocol CIFS it is mandatory to add a security service to the share network beforehand. If this is forgotten the share ends up in error, but the user message produced is not helping my users to help themselves.

Steps to reproduce
==================

* create a share with protocol CIFS (select a share network that does not have a security service assigned)

Expected result
===============
A) A user message tells me: ERROR - "create: share network security service association is mandatory for protocol CIFS" or something like that

or:

B) Validation happens early and the create command directly reports an invalid request

Actual result
=============
* share ends up in error state
* user message is produced ERROR - "create: An unknown error occurred."

As a cloud administrator it is even not easy to figure out what went wrong, because the error you get in the logs is "NetApp API failed. Reason - 13001:Failed to get CIFS server. Reason: CIFS server doesn't exist." out of create_cifs_share in manila/share/drivers/netapp/dataontap/client/client_cmode.py

Environment
===========
1. Manila on Train Release (with some unrelated changes in a custom fork (https://github.com/sapcc/manila/tree/stable/train-m3)

2. NetApp Ontap 9.7p7 backend

3. DHSS=true (neutron bind)

Logs & Configs
==============

http://paste.openstack.org/show/799225/

Best regards,
Maurice

[Vida Haririan (vhariria)]

Additional comments http://eavesdrop.openstack.org/meetings/manila/2020/manila.2020-11-12-15.01.log.html

[kiran pawar (kpdev)]

Please check RFC PR - https://review.opendev.org/c/openstack/manila/+/776875

[Vida Haririan (vhariria)]

Additional comments https://meetings.opendev.org/meetings/manila/2021/manila.2021-06-24-15.00.log.html

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/776875
Committed: https://opendev.org/openstack/manila/commit/18668d24652b653cb2b562d4708b87ba99794b85
Submitter: "Zuul (22348)"
Branch: master

commit 18668d24652b653cb2b562d4708b87ba99794b85
Author: kpdev <email address hidden>
Date: Mon Feb 22 08:29:43 2021 +0100

    Early validate for CIFS without security service.

    To create a share with protocol CIFS it is mandatory to add a security
    service to the share network beforehand. If this is forgotten the share
    ends up in error. Validate the security service association based on
    share protocol from given driver. Raise invalid request exception if
    needed association between share_network and security_service is
    missing for given driver e.g. ONTAP.

    DocImpact

    Closes-Bug: #1900752
    Change-Id: Ib7e9850e6439ee5d04f826d129afb1ab06950ce7

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 13.0.0.0rc1 release candidate.