rally source build provides a broken virtualenv

[Michal Nasiadka]

Kola in openstack-base installs virtualenv without taking upper-constraints into consideration, and when rally has virtualenv in requirements.txt it tries to downgrade virtualenv inside a Kolla virtualenv - which obviously fails and renders rally broken.

Kolla-build log for rally container:
INFO:kolla.common.utils.rally: Attempting uninstall: virtualenv
INFO:kolla.common.utils.rally: Found existing installation: virtualenv 20.0.35
INFO:kolla.common.utils.rally: Not uninstalling virtualenv at /usr/local/lib/python3.6/site-packages, outside environment /var/lib/kolla/venv
INFO:kolla.common.utils.rally: Can't uninstall 'virtualenv'. No files were found to uninstall.
INFO:kolla.common.utils.rally:Successfully installed distlib-0.3.0 future-0.18.2 importlib-resources-1.4.0 os-testr-2.0.0 paramiko-2.7.1 python-subunit-1.4.0 rally-3.1.0 stestr-3.0.1 virtualenv-20.0.17

rally verifier log:
2020-10-16 09:56:05.040 35 ERROR rally.verification.utils [-] Error output: 'ModuleNotFoundError: No module named 'virtualenv.seed.embed.via_app_data'
': subprocess.CalledProcessError: Command '['virtualenv', '-p', '/var/lib/kolla/venv/bin/python', '/var/lib/rally/.rally/verification/verifier-97595ac8-87b1-422c-88be-978eebe34cb3/.venv']' returned non-zero exit status 1.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/758553
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=b1709a87ed6bead417a3cd6848de068e06190370
Submitter: Zuul
Branch: master

commit b1709a87ed6bead417a3cd6848de068e06190370
Author: Michal Nasiadka <email address hidden>
Date: Fri Oct 16 13:10:03 2020 +0200

    Use upper constraints for virtualenv in openstack-base

    Since Rally has virtualenv in requirements, and is using contraints - it's
    trying to downgrade virtualenv from inside a virtualenv.
    Let's try to install proper version of packages in openstack-base.

    Closes-Bug: #1900419
    Change-Id: I2a1e2b6661fd4b62648756416e6147b604dda686

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/760566

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/760566
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=bebad0409ea1f4a6b9de8051821f6b3fa444aca3
Submitter: Zuul
Branch: stable/ussuri

commit bebad0409ea1f4a6b9de8051821f6b3fa444aca3
Author: Michal Nasiadka <email address hidden>
Date: Fri Oct 16 13:10:03 2020 +0200

    Use upper constraints for virtualenv in openstack-base

    Since Rally has virtualenv in requirements, and is using contraints - it's
    trying to downgrade virtualenv from inside a virtualenv.
    Let's try to install proper version of packages in openstack-base.

    Closes-Bug: #1900419
    Change-Id: I2a1e2b6661fd4b62648756416e6147b604dda686
    (cherry picked from commit b1709a87ed6bead417a3cd6848de068e06190370)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla 10.2.0 release.