make links in Preferences readable

[ronso0]

I have a dark OS theme and the file links in the controller page are barely readable, blue on dark grey.
I tried several themes in xfce4, all show the links in blue,
so I assume the font color is set by a default Qt palette and it's not defined in GTK themes. And there's no easy way to adjust the palette, not even with Qt Settings app.

Can anyone (on *Ubuntu) confirm this?

[ronso0 (ronso0)]

guess I'll fix this when I include the WTrackProperties and DlgTagFetcher dialogs in the skins' color themes.

[ronso0 (ronso0)]

...because it seems impossible to pick a palette color and apply it to links in DlgController(s).

[ronso0 (ronso0)]

oh, there is a possible fix:
for all links that are generated in c++ I can add style="color:..."
I created a color helper function that blends two colors 50/50.
If I blend the palette colors 'text' and 'link' the visibility is greatly improved!

Obviously this doesn't work for links written in UI files. To fix those, too, I'd need to move some translation strings to cpp.
AFAICT this mostly only affects short strings like 'Mixxx Forums' and 'Troubleshooting', but there's also the long text in the Pref > Controllers root page.
Does moving that to cpp violate the string freeze? The text itself would remain unchanged so I guess this doesn't creat too much trouble for translators.

Opinions?
if there are no objections I'll start a PR because this makes the file links etc. finally usable for me.

[ronso0 (ronso0)]

https://github.com/mixxxdj/mixxx/pull/3464

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10170