Patron password use phone not working

[Steve Callender]

It looks like on 3.5 the seetting,

patron.password.use_phone

Is not working. When having that set to true, entering a patron phone number, there is an error in the console,

vendor.bundle.js:6 TypeError: Cannot read property 'old' of undefined
    at f.$scope.handle_field_changed (regctl.js:2049)
    at fn (eval at compile (vendor.bundle.js:6), <anonymous>:4:286)
    at r (vendor.bundle.js:6)
    at f.$eval (vendor.bundle.js:6)
    at f.$apply (vendor.bundle.js:6)
    at HTMLInputElement.<anonymous> (vendor.bundle.js:6)
    at HTMLInputElement.dispatch (jquery.min.js:2)
    at HTMLInputElement.v.handle (jquery.min.js:2)

This does not happen on 3.4 and below, so it looks like some change introduced in 3.5 may have caused this. Tested on multiple 3.5 systems.

Steve

[April Durrence (april-durrence)]

NC Cardinal just upgraded to version 3.5.1 and multiple libraries are reporting the same problem.

[Terran McCanna (tmccanna)]

Bumping this to High - this is going to be a significant problem for PINES if it's not fixed before we upgrade in January

[Cheryl Middleton (cheryl-middleton)]

It is a significant issue for members of NCCardinal with upgrade to 3.5.1 over the weekend. I've had to send out urgent retraining docs to all staff in our system because this bug changes
how we've operated in Evergreen since 2011.

[Dan Briem (dbriem)]

Here's a branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp_1900184_patron_pwd_use_phone

An early return statement in extract_hold_notify() (circ/patron/regctl.js) is preventing props from being set on $scope that are required for future comparisons. The return statement was removed in the fix to bug 1570072 and added back in the fix to bug 1774268.

[Garry Collum (gcollum)]

Tested Dan's branch and the patch works as advertised. A signed-off branch is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp_1900184_patron_pwd_use_phone-signoff

[Jason Boyer (jboyer)]

I should have looked a little harder at the fix for 1570072. Pushed to rel_3_5, rel_3_6, and master, thanks Dan and Garry!