dm-writeboost dkms: build failure with linux-hwe-5.8

[Andrea Righi]

[Impact]

The following build error is reported when building this module with the new linux-hwe-5.8:

/var/lib/dkms/dm-writeboost/2.2.9/build/dm-writeboost-daemon.c:62:13: error: too many arguments to function ‘blkdev_issue_flush’
   62 | int err = blkdev_issue_flush(wb->cache_dev->bdev, GFP_NOIO, NULL);
      | ^~~~~~~~~~~~~~~~~~

[Test case]

$ sudo apt install dm-writeboost-dkms

Build error in reported in the build log.

[Fix]

Fix by applying 2 patches from the groovy dkms module to properly support a 5.8 kernel.

[Regression potential]

The source code for the 5.4 kernel remains the same, so there is no regression potential. The new changes are all conditionals and they are all applied to the 5.8 kernel.

[Andrea Righi (arighi)]

The attached debdiff fixes all the build errors and module can be loaded correctly on linux-hwe-5.8.

[Andrea Righi (arighi)]

Edit: report the correct LP bug number in the changelog.

[Andy Whitcroft (apw)]

Hello Andrea, or anyone else affected,

Accepted dm-writeboost into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dm-writeboost/2.2.9-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Kleber Sacilotto de Souza (kleber-souza)]

dm-writeboost 2.2.9-1ubuntu1.1 ADT completely successfully:

focal/linux 5.4:
- amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/d/dm-writeboost/20201103_155145_1dff6@/log.gz
- arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/arm64/d/dm-writeboost/20201103_160227_67adf@/log.gz
- ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/ppc64el/d/dm-writeboost/20201103_155926_10adc@/log.gz
- s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/s390x/d/dm-writeboost/20201103_155031_67adf@/log.gz

Focal/linux-hwe 5.8:
- amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/d/dm-writeboost/20201110_170140_10392@/log.gz
- arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/arm64/d/dm-writeboost/20201110_170732_347ef@/log.gz
- ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/ppc64el/d/dm-writeboost/20201110_170306_10392@/log.gz
- s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/s390x/d/dm-writeboost/20201110_170018_347ef@/log.gz

I have also installed/compiled/loaded the dkms module in a Focal VM running both linux 5.4 and linux-hwe 5.8.

[Launchpad Janitor (janitor)]

This bug was fixed in the package dm-writeboost - 2.2.9-1ubuntu1.1

---------------
dm-writeboost (2.2.9-1ubuntu1.1) focal; urgency=medium

  * Linux 5.8 compatibility (LP: #1899604):
    - debian/patches/0002-fix-missing-stat-header.patch
    - debian/patches/0003-Fix-Linux-5.8-build-gc-error-parameter-from-blkdev_i.patch

 -- Andrea Righi <email address hidden> Tue, 13 Oct 2020 09:29:19 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for dm-writeboost has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.