formatting error causes exception in running agent

Bug #1898789 reported by thefish
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Nate Johnston

Bug Description

agent/linux/external_process.py:116 contains a formatting error resulting in an exception in some cases (using {}braces instead of ()brackets)

Sorry, this is a simple fix but i cant find how to send a pull request, pls see attached patch against master

Revision history for this message
thefish (captainmish) wrote :
Changed in neutron:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Nate Johnston (nate-johnston)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/756610

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
Nate Johnston (nate-johnston) wrote :

Thanks for the patch, I pushed it to gerrit here: https://review.opendev.org/756610

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/756610
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=24cd8598dcbedf51838fc737938d5d764ba14147
Submitter: Zuul
Branch: master

commit 24cd8598dcbedf51838fc737938d5d764ba14147
Author: Nate Johnston <email address hidden>
Date: Wed Oct 7 21:05:48 2020 -0400

    Fix formatting error in agent/linux/external_process.py

    Formatting error causes exception in certain circumstances; fix is
    trivial.

    Co-Authored-By: <email address hidden>
    Change-Id: I2bd7f2f3d798228fee6ba26d0e1a32e3033e9fc1
    Closes-Bug: #1898789

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/761483

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/761484

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/761485

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/761485
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f077319ebc3c4fa0cfdc618402b673540891a0da
Submitter: Zuul
Branch: stable/victoria

commit f077319ebc3c4fa0cfdc618402b673540891a0da
Author: Nate Johnston <email address hidden>
Date: Wed Oct 7 21:05:48 2020 -0400

    Fix formatting error in agent/linux/external_process.py

    Formatting error causes exception in certain circumstances; fix is
    trivial.

    Co-Authored-By: <email address hidden>
    Change-Id: I2bd7f2f3d798228fee6ba26d0e1a32e3033e9fc1
    Closes-Bug: #1898789
    (cherry-picked from commit 24cd8598dcbedf51838fc737938d5d764ba14147)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/train)

Reviewed: https://review.opendev.org/761484
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9c082125764903267abfe8318cd8ea90b5405959
Submitter: Zuul
Branch: stable/train

commit 9c082125764903267abfe8318cd8ea90b5405959
Author: Nate Johnston <email address hidden>
Date: Wed Oct 7 21:05:48 2020 -0400

    Fix formatting error in agent/linux/external_process.py

    Formatting error causes exception in certain circumstances; fix is
    trivial.

    Co-Authored-By: <email address hidden>
    Change-Id: I2bd7f2f3d798228fee6ba26d0e1a32e3033e9fc1
    Closes-Bug: #1898789
    (cherry-picked from commit 24cd8598dcbedf51838fc737938d5d764ba14147)

tags: added: in-stable-train
tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/761483
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b9c2dd48fa2f36356fc4aa0f6e60f8cdc050b4b6
Submitter: Zuul
Branch: stable/ussuri

commit b9c2dd48fa2f36356fc4aa0f6e60f8cdc050b4b6
Author: Nate Johnston <email address hidden>
Date: Wed Oct 7 21:05:48 2020 -0400

    Fix formatting error in agent/linux/external_process.py

    Formatting error causes exception in certain circumstances; fix is
    trivial.

    Co-Authored-By: <email address hidden>
    Change-Id: I2bd7f2f3d798228fee6ba26d0e1a32e3033e9fc1
    Closes-Bug: #1898789
    (cherry-picked from commit 24cd8598dcbedf51838fc737938d5d764ba14147)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 15.3.1

This issue was fixed in the openstack/neutron 15.3.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 16.3.0

This issue was fixed in the openstack/neutron 16.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 17.1.0

This issue was fixed in the openstack/neutron 17.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.0.0.0rc1

This issue was fixed in the openstack/neutron 18.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.